New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GWT regression in lombok 0.10.4 (NoClassDefFoundError org/eclipse/jdt/core/dom/ASTNode) #393

Closed
lombokissues opened this Issue Jul 14, 2015 · 10 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 320)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 20, 2011 at 15:27 UTC

What steps will reproduce the problem?

  1. Run the GWT compiler on lombok-using code. (A sample is attached, but I see this on every project.)
  2. The compiler tries to class-load some JDT code but cannot, so crashes.
  3. This happens on both the command-line and from within eclipse.

What version of the product are you using? On what operating system?

GWT 2.4.0
Lombok 0.10.4 and 0.10.6 in Eclipse 3.7.1 on Ubuntu 10.04
OpenJDK Runtime Environment (IcedTea6 1.9.9) (6b20-1.9.9-0ubuntu1~10.04.2)

Please provide any additional information below.

It appears that the recent eclipse-integration fixes introduced some
<clinit>-time dependencies into the eclipse JDT.

With lombok 0.10.4, gwtc starts to require
org/eclipse/jdt/core/dom/ASTNode
on the classpath; with 0.10.6, gwtc additionally requires
org/eclipse/jdt/core/dom/BodyDeclaration and
org/eclipse/jdt/core/dom/MethodDeclaration.

As a work-around, I can put (all or part of) the eclipse JDT
org.eclipse.jdt.core_3.7.1.v_B76_R37x.jar
on my classpath. Previously, I only had to have GWT's embedded copy
of ECJ on my classpath (i.e., the
org/eclipse/jdt/core/compiler and
org/eclipse/jdt/internal/compiler packages).

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 20, 2011 at 15:27 UTC

What steps will reproduce the problem?

  1. Run the GWT compiler on lombok-using code. (A sample is attached, but I see this on every project.)
  2. The compiler tries to class-load some JDT code but cannot, so crashes.
  3. This happens on both the command-line and from within eclipse.

What version of the product are you using? On what operating system?

GWT 2.4.0
Lombok 0.10.4 and 0.10.6 in Eclipse 3.7.1 on Ubuntu 10.04
OpenJDK Runtime Environment (IcedTea6 1.9.9) (6b20-1.9.9-0ubuntu1~10.04.2)

Please provide any additional information below.

It appears that the recent eclipse-integration fixes introduced some
<clinit>-time dependencies into the eclipse JDT.

With lombok 0.10.4, gwtc starts to require
org/eclipse/jdt/core/dom/ASTNode
on the classpath; with 0.10.6, gwtc additionally requires
org/eclipse/jdt/core/dom/BodyDeclaration and
org/eclipse/jdt/core/dom/MethodDeclaration.

As a work-around, I can put (all or part of) the eclipse JDT
org.eclipse.jdt.core_3.7.1.v_B76_R37x.jar
on my classpath. Previously, I only had to have GWT's embedded copy
of ECJ on my classpath (i.e., the
org/eclipse/jdt/core/compiler and
org/eclipse/jdt/internal/compiler packages).

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 20, 2011 at 15:27 UTC

🔗 ProjectName.tgz

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 20, 2011 at 15:27 UTC

🔗 ProjectName.tgz

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 askoning   🕗 Dec 22, 2011 at 12:26 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 askoning   🕗 Dec 22, 2011 at 12:26 UTC

@lombokissues lombokissues added the gwt label Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 22, 2011 at 22:12 UTC

I realize I should have included the exception trace, here it is:

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 22, 2011 at 22:12 UTC

I realize I should have included the exception trace, here it is:

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Dec 22, 2011 at 22:12 UTC

🔗 lombok320.txt View file

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Dec 22, 2011 at 22:12 UTC

🔗 lombok320.txt View file

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jan 02, 2012 at 19:35 UTC

I need to yell at some people for not using transplant() whilst writing the patchers. Or probably yell at my self for not explaining that you need to do that.

Fixed.

You can download the edge release if you can't wait: https://projectlombok.org/download-edge.html

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jan 02, 2012 at 19:35 UTC

I need to yell at some people for not using transplant() whilst writing the patchers. Or probably yell at my self for not explaining that you need to do that.

Fixed.

You can download the edge release if you can't wait: https://projectlombok.org/download-edge.html

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jan 02, 2012 at 20:19 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jan 02, 2012 at 20:19 UTC

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jan 02, 2012 at 20:20 UTC

Robbert Jan and I also added a test to make sure this regression won't happen a second time.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jan 02, 2012 at 20:20 UTC

Robbert Jan and I also added a test to make sure this regression won't happen a second time.

@lombokissues lombokissues added this to the 0.10.8 milestone Jul 14, 2015

@lombokissues lombokissues removed the gwt label Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jwnimmer@jaybridge.com   🕗 Jan 03, 2012 at 15:37 UTC

Thank you folks, the edge release works great for us now.

Collaborator

lombokissues commented Jul 14, 2015

👤 jwnimmer@jaybridge.com   🕗 Jan 03, 2012 at 15:37 UTC

Thank you folks, the edge release works great for us now.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment