New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Delegate @Getter(lazy=true) doesn't work. #401

Closed
lombokissues opened this Issue Jul 14, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 328)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Jan 18, 2012 at 23:42 UTC

This should translate to: As if the @ Delegate was on the getX() method instead.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Jan 18, 2012 at 23:42 UTC

This should translate to: As if the @ Delegate was on the getX() method instead.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 23, 2012 at 20:56 UTC

If @ Delegate is put on a field that also has @ Getter(lazy=true), the getter should be used in all delegated methods instead of the fields directly.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 23, 2012 at 20:56 UTC

If @ Delegate is put on a field that also has @ Getter(lazy=true), the getter should be used in all delegated methods instead of the fields directly.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 23, 2012 at 21:42 UTC

(Also, if @ Delegate does not explicitly specify a type, we should use the original type of the field. In the case of @ Delegate @ Getter(lazy=true), we currently substitute the AtomicReference created by the lazy getter.)

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 23, 2012 at 21:42 UTC

(Also, if @ Delegate does not explicitly specify a type, we should use the original type of the field. In the case of @ Delegate @ Getter(lazy=true), we currently substitute the AtomicReference created by the lazy getter.)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 23, 2012 at 23:10 UTC

On second thought, I think we should always use the getter if we generate one. Not only if lazy=true

We do have an opt-out mechanism for this in @ EqualsAndHashCode. At this point we don't see a need for this in @ Delegate.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 23, 2012 at 23:10 UTC

On second thought, I think we should always use the getter if we generate one. Not only if lazy=true

We do have an opt-out mechanism for this in @ EqualsAndHashCode. At this point we don't see a need for this in @ Delegate.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 24, 2012 at 02:15 UTC

Feature added in fc7ca61

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 24, 2012 at 02:15 UTC

Feature added in fc7ca61

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Feb 15, 2012 at 03:38 UTC

Will be in version following 0.10.8

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Feb 15, 2012 at 03:38 UTC

Will be in version following 0.10.8

@lombokissues lombokissues added this to the 0.10.9 milestone Jul 14, 2015

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment