New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@SneakyThrows causes Eclipse refactoring 'surround with try/catch' to fail #511

Closed
lombokissues opened this Issue Jul 14, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 438)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 jorn86   🕗 Dec 13, 2012 at 10:02 UTC

What steps will reproduce the problem?

  1. Put @ SneakyThrows with a parameter (so it doesn't catch everything) on a method
  2. Inside the method, throw an uncaught exception, Eclipse will show an error
  3. Use the Eclipse quick fix 'surround with try/catch' or 'surround with try/multicatch'
  4. The code throwing the exception will be deleted instead of putting it inside a block.

What is the expected output? What do you see instead?
Expected: Code in try/catch block. Actual: No code.

What version of the product are you using? On what operating system?
Eclipse 3.7.1, Windows 7

Please provide any additional information below.
Feel free to have Roel or RJ come by my desk so I can show him :)

Collaborator

lombokissues commented Jul 14, 2015

👤 jorn86   🕗 Dec 13, 2012 at 10:02 UTC

What steps will reproduce the problem?

  1. Put @ SneakyThrows with a parameter (so it doesn't catch everything) on a method
  2. Inside the method, throw an uncaught exception, Eclipse will show an error
  3. Use the Eclipse quick fix 'surround with try/catch' or 'surround with try/multicatch'
  4. The code throwing the exception will be deleted instead of putting it inside a block.

What is the expected output? What do you see instead?
Expected: Code in try/catch block. Actual: No code.

What version of the product are you using? On what operating system?
Eclipse 3.7.1, Windows 7

Please provide any additional information below.
Feel free to have Roel or RJ come by my desk so I can show him :)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Feb 20, 2014 at 20:33 UTC

This bug got fixed by the same commit as the fix for issue #668.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Feb 20, 2014 at 20:33 UTC

This bug got fixed by the same commit as the fix for issue #668.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment