New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java 8 language support to Eclipse #632

Closed
lombokissues opened this Issue Jul 14, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 597)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Oct 22, 2013 at 16:13 UTC

Add java 8 language support to Eclipse

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Oct 22, 2013 at 16:13 UTC

Add java 8 language support to Eclipse

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 cbeams   🕗 Nov 08, 2013 at 12:03 UTC

Not sure whether this issue is addressing my concern directly, but I just ran into errors while working with:

  1. Lombok 1.12.2
  2. JDK 8 (b108)
  3. STS 3.4.0.RELEASE
  4. early Eclipse JDT support for Java 8 as installed from http://dist.springsource.com/snapshot/TOOLS/java8/e43

Prior to the installation of (4), Lombok was working as expected. After installation I get dozens of the following error (see attached for details).

Lombok annotation handler class lombok.eclipse.handlers.HandleData failed

At a glance, it looks like the JDT API has some breaking changes in these patches that support JDK 8, and this is causing Lombok to blow up with NoSuchMethodErrors.

Do let me know if I should create a separate issue to address this problem.

Thanks!

Collaborator

lombokissues commented Jul 14, 2015

👤 cbeams   🕗 Nov 08, 2013 at 12:03 UTC

Not sure whether this issue is addressing my concern directly, but I just ran into errors while working with:

  1. Lombok 1.12.2
  2. JDK 8 (b108)
  3. STS 3.4.0.RELEASE
  4. early Eclipse JDT support for Java 8 as installed from http://dist.springsource.com/snapshot/TOOLS/java8/e43

Prior to the installation of (4), Lombok was working as expected. After installation I get dozens of the following error (see attached for details).

Lombok annotation handler class lombok.eclipse.handlers.HandleData failed

At a glance, it looks like the JDT API has some breaking changes in these patches that support JDK 8, and this is causing Lombok to blow up with NoSuchMethodErrors.

Do let me know if I should create a separate issue to address this problem.

Thanks!

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 cbeams   🕗 Nov 08, 2013 at 12:03 UTC

Collaborator

lombokissues commented Jul 14, 2015

👤 cbeams   🕗 Nov 08, 2013 at 12:03 UTC

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Nov 08, 2013 at 13:08 UTC

No, for now I think this is fine.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Nov 08, 2013 at 13:08 UTC

No, for now I think this is fine.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 andrePankraz   🕗 Dec 28, 2013 at 19:27 UTC

Added Eclipse BUG:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=424718

Works with this change.

Collaborator

lombokissues commented Jul 14, 2015

👤 andrePankraz   🕗 Dec 28, 2013 at 19:27 UTC

Added Eclipse BUG:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=424718

Works with this change.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 andrePankraz   🕗 Jan 24, 2014 at 19:23 UTC

bug in eclipse is now fixed, should be OK in release

Collaborator

lombokissues commented Jul 14, 2015

👤 andrePankraz   🕗 Jan 24, 2014 at 19:23 UTC

bug in eclipse is now fixed, should be OK in release

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Feb 27, 2014 at 20:40 UTC

We found an issue with val and lambdas. Something like this is fairly silly:

val r = someBool ? () -> 5 : () -> 7;

but you can type it, and it would cause exceptions if lombok was loaded. That's been fixed. This more common case:

val r = () -> System.out.println();

Even gets a special error message explaining that lambdas just don't work that way.

We did some more toying with JDK8 features in Eclipse Kepler with the JDK8 patch plugin, and didn't run into any major issues. 'val' in lambdas works, @ Cleanup in lambdas works, etc. I'm not closing this issue yet, as I want to do a little more testing, especially as we get closer to the official Luna release and the official JDK8 release.

This update (Fixing issues with val and lambdas) is in edge, here:

https://projectlombok.org/download-edge.html

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Feb 27, 2014 at 20:40 UTC

We found an issue with val and lambdas. Something like this is fairly silly:

val r = someBool ? () -> 5 : () -> 7;

but you can type it, and it would cause exceptions if lombok was loaded. That's been fixed. This more common case:

val r = () -> System.out.println();

Even gets a special error message explaining that lambdas just don't work that way.

We did some more toying with JDK8 features in Eclipse Kepler with the JDK8 patch plugin, and didn't run into any major issues. 'val' in lambdas works, @ Cleanup in lambdas works, etc. I'm not closing this issue yet, as I want to do a little more testing, especially as we get closer to the official Luna release and the official JDK8 release.

This update (Fixing issues with val and lambdas) is in edge, here:

https://projectlombok.org/download-edge.html

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment