New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding of the delombok files should have the same encoding as input files #794

Closed
lombokissues opened this Issue Jul 14, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 759)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 Krzysztof.Krzeminski   🕗 Dec 05, 2014 at 09:17 UTC

What steps will reproduce the problem?

  1. Input java class should have javadocs with eg polish letters 'zażółć jaźńgęślą'
  2. Input java shoul be UTF8 encoded
  3. Call Delombok task

What is the expected output? What do you see instead?
'zażółć jaźńgęślą' should be in docs

you get 'za\u017có\u0142\u0107 ja\u017a\u0144g\u0119\u015bl\u0105'

What version of the product are you using? On what operating system?
'org.projectlombok:lombok:1.14.8'

Please provide any additional information below.

Delombok should call writer with encoding charset if charset is given

private Writer createStandardOutWriter() {
    return createUnicodeEscapeWriter(System.out);
}

private Writer createUnicodeEscapeWriter(OutputStream out) {
    return new UnicodeEscapeWriter(new OutputStreamWriter(out, charset), charset);
}
Collaborator

lombokissues commented Jul 14, 2015

👤 Krzysztof.Krzeminski   🕗 Dec 05, 2014 at 09:17 UTC

What steps will reproduce the problem?

  1. Input java class should have javadocs with eg polish letters 'zażółć jaźńgęślą'
  2. Input java shoul be UTF8 encoded
  3. Call Delombok task

What is the expected output? What do you see instead?
'zażółć jaźńgęślą' should be in docs

you get 'za\u017có\u0142\u0107 ja\u017a\u0144g\u0119\u015bl\u0105'

What version of the product are you using? On what operating system?
'org.projectlombok:lombok:1.14.8'

Please provide any additional information below.

Delombok should call writer with encoding charset if charset is given

private Writer createStandardOutWriter() {
    return createUnicodeEscapeWriter(System.out);
}

private Writer createUnicodeEscapeWriter(OutputStream out) {
    return new UnicodeEscapeWriter(new OutputStreamWriter(out, charset), charset);
}
@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 r.spilker   🕗 Jan 03, 2015 at 16:41 UTC

This has been fixed in 091f6ee and will be part of the next release. I've also added some test cases to make sure it will keep working.

Collaborator

lombokissues commented Jul 14, 2015

👤 r.spilker   🕗 Jan 03, 2015 at 16:41 UTC

This has been fixed in 091f6ee and will be part of the next release. I've also added some test cases to make sure it will keep working.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment