Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Lombok 1.16.4 breaks quickfix on eclipse mars RC3 #861
What steps will reproduce the problem?
What is the expected output? What do you see instead?
What version of the product are you using? On what operating system?
Please provide any additional information below.
The fix for issue #398 is causing this. Specifically, the pos fixer for retrieveRightBrace, found in PatchFixes' fixRetrieveRightBraceOrSemiColonPosition, is being applied to 'fix' the positions of some imaginary code that the quickfix tool is trying to display to help in showing what's going to happen here, and this causes the crashes. Note that these occur even if zero lombok anything is in your source file.
The relevant stack trace for when fixRetrieveRightBraceOrSemiColonPosition kicks in but should not, is this:
and this stack trace is the 'top' either on hitting CTRL+1 or on trying to apply it.
We can disable this patch but that would re-break 325. We need to be smarter about when to fix and when to skip it, or alternatively we need to fix what this meant to fix (325, amongst other things) elsewhere.