New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lombok prevents the Eclipse help to launch #99

Closed
lombokissues opened this Issue Jul 14, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 26)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 olivier.hubaut   🕗 Aug 10, 2009 at 08:31 UTC

What steps will reproduce the problem?

  1. Install Lombok
  2. Run Eclipse Ganymede or Eclipse Galileo
  3. Try launching the Help Contents.

What is the expected output? What do you see instead?

Expected output is, of course, to have the help launched.
Instead, a 500 error code is thrown by Jetty, the underlying server that
runs the help.

What version of the product are you using? On what operating system?

Eclipse 3.4 and 3.5, both on Windows

Please provide any additional information below.

It seems that lombok try to modify either the jetty or help jars at
launch, which is an unexpected behaviour. The
org.eclipse.core.runtime.IStatus is the class that is impacted.

Collaborator

lombokissues commented Jul 14, 2015

👤 olivier.hubaut   🕗 Aug 10, 2009 at 08:31 UTC

What steps will reproduce the problem?

  1. Install Lombok
  2. Run Eclipse Ganymede or Eclipse Galileo
  3. Try launching the Help Contents.

What is the expected output? What do you see instead?

Expected output is, of course, to have the help launched.
Instead, a 500 error code is thrown by Jetty, the underlying server that
runs the help.

What version of the product are you using? On what operating system?

Eclipse 3.4 and 3.5, both on Windows

Please provide any additional information below.

It seems that lombok try to modify either the jetty or help jars at
launch, which is an unexpected behaviour. The
org.eclipse.core.runtime.IStatus is the class that is impacted.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Aug 11, 2009 at 09:34 UTC

Good find, Olivier. The help is built from JSP files, which need to be compiled, which eclipse does with its own
parser, which has been instrumented by lombok. Lombok is indeed at fault.

Will look at fixing it later. For now marking it as valid.

I wish java itself was developed when lombok already existed, because the ClassCastException isn't being
THROWN, it's being passed someplace which isn't legal and is causing an IllegalArgumentException, which
prints the toString() of the ClassCastException, which for whatever reason doesn't have a useful toString().
D'oh!

The stack trace generated is:

java.lang.IllegalArgumentException: java.lang.ClassCastException@ 115b920e
at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
java.lombok.eclipse.ClassLoaderWorkaround.transformCompilationUnitDeclaration(ClassLoaderWorkaround.ja
va:57)
at org.eclipse.jdt.internal.compiler.parser.Parser.endParse(Parser.java:7638)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8497)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8657)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8622)
at org.eclipse.jdt.internal.compiler.parser.Parser.dietParse(Parser.java:7420)
at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:289)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:315)
at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:404)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:297)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:276)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:264)
at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:563)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:303)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.equinox.jsp.jasper.JspServlet.service(JspServlet.java:112)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.eclipse.equinox.http.registry.internal.ServletManager$ServletWrapper.service(ServletManager.java:180)
at org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:75)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManag
er.java:318)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:380)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:324)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:535)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:865)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:540)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:213)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:520)

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Aug 11, 2009 at 09:34 UTC

Good find, Olivier. The help is built from JSP files, which need to be compiled, which eclipse does with its own
parser, which has been instrumented by lombok. Lombok is indeed at fault.

Will look at fixing it later. For now marking it as valid.

I wish java itself was developed when lombok already existed, because the ClassCastException isn't being
THROWN, it's being passed someplace which isn't legal and is causing an IllegalArgumentException, which
prints the toString() of the ClassCastException, which for whatever reason doesn't have a useful toString().
D'oh!

The stack trace generated is:

java.lang.IllegalArgumentException: java.lang.ClassCastException@ 115b920e
at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
java.lombok.eclipse.ClassLoaderWorkaround.transformCompilationUnitDeclaration(ClassLoaderWorkaround.ja
va:57)
at org.eclipse.jdt.internal.compiler.parser.Parser.endParse(Parser.java:7638)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8497)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8657)
at org.eclipse.jdt.internal.compiler.parser.Parser.parse(Parser.java:8622)
at org.eclipse.jdt.internal.compiler.parser.Parser.dietParse(Parser.java:7420)
at org.eclipse.jdt.internal.compiler.Compiler.beginToCompile(Compiler.java:289)
at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:315)
at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:404)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:297)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:276)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:264)
at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:563)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:303)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at org.eclipse.equinox.jsp.jasper.JspServlet.service(JspServlet.java:112)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.eclipse.equinox.http.registry.internal.ServletManager$ServletWrapper.service(ServletManager.java:180)
at org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
at org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
at org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:75)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
at
org.eclipse.equinox.http.jetty.internal.HttpServerManager$InternalHttpServiceServlet.service(HttpServerManag
er.java:318)
at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502)
at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:380)
at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
at org.mortbay.jetty.Server.handle(Server.java:324)
at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:535)
at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:865)
at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:540)
at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:213)
at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:520)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Aug 31, 2009 at 22:11 UTC

This has been fixed in commit 72cc800 and will be rolled out in v0.8.4.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Aug 31, 2009 at 22:11 UTC

This has been fixed in commit 72cc800 and will be rolled out in v0.8.4.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Oct 16, 2009 at 08:51 UTC

Some changes to lombok that will go live in v0.9 may cause a recurrence of this bug, though I tested it, and it
doesn't seem to be occurring.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Oct 16, 2009 at 08:51 UTC

Some changes to lombok that will go live in v0.9 may cause a recurrence of this bug, though I tested it, and it
doesn't seem to be occurring.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment