Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow @Builder on instance methods #63
This is a simple extension to allow
This looks great. Well done! Roel was particularly enamoured by the inclusion of some unit tests
We need three more things before we can accept this pull request:
Thanks @rzwitserloot, I'm glad the PR is well received.
I performed those three changes you mentioned. However, I'm still unconvinced that Builders for instance methods should be non-static classes and not simply static classes with an explicit reference to the outer class given to it's constructor. The reason is that I'd like this to also work for interfaces and it is not possible to define non-static classes inside interfaces (afaik). I understand this isn't particularly useful right now because the builder method is always defined (and will fail with "interface method cannot have a body"), but with a few additional changes:
What do you think?