New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for builder singular for Guavas ImmutableTable #937

Merged
merged 2 commits into from Nov 17, 2015

Conversation

Projects
None yet
3 participants
@spacanowski
Contributor

spacanowski commented Oct 4, 2015

Pull request will resolve #917

@rspilker

This comment has been minimized.

Show comment
Hide comment
@rspilker

rspilker Oct 7, 2015

Thanks for adding this feature!

I've just had a 10 minute look at the change and have some remarks:

  • For legal reasons, we need you to add your name to the AUTHORS file
  • There is a typo in the method name: getTypeAgrumentsCount should have been getTypeArgumentsCount. Also, the local variables contain this type
  • Great that you also updated the documentation and tests
  • The white-space formatting and imports have also changed. To make it easier to see the actual changes in a diff, and later for tracking modifications, it would be great if you can restore the original import order and whitespace as much as possible.

Thanks for adding this feature!

I've just had a 10 minute look at the change and have some remarks:

  • For legal reasons, we need you to add your name to the AUTHORS file
  • There is a typo in the method name: getTypeAgrumentsCount should have been getTypeArgumentsCount. Also, the local variables contain this type
  • Great that you also updated the documentation and tests
  • The white-space formatting and imports have also changed. To make it easier to see the actual changes in a diff, and later for tracking modifications, it would be great if you can restore the original import order and whitespace as much as possible.
@spacanowski

This comment has been minimized.

Show comment
Hide comment
@spacanowski

spacanowski Oct 8, 2015

Contributor

Changes done.
I left removing of leading and only in line whitespaces (easier to read when you have whitespace showing turned on in IDE).
Method getTypeArgumentsCount (fixed typo) is required for raw collections (without specified generics).

Contributor

spacanowski commented Oct 8, 2015

Changes done.
I left removing of leading and only in line whitespaces (easier to read when you have whitespace showing turned on in IDE).
Method getTypeArgumentsCount (fixed typo) is required for raw collections (without specified generics).

@rzwitserloot rzwitserloot merged commit 22e1fb9 into rzwitserloot:master Nov 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment