Added support for builder singular for Guavas ImmutableTable #937

Merged
merged 2 commits into from Nov 17, 2015

Projects

None yet

3 participants

@spacanowski
Contributor

Pull request will resolve #917

@rspilker
Collaborator

Thanks for adding this feature!

I've just had a 10 minute look at the change and have some remarks:

  • For legal reasons, we need you to add your name to the AUTHORS file
  • There is a typo in the method name: getTypeAgrumentsCount should have been getTypeArgumentsCount. Also, the local variables contain this type
  • Great that you also updated the documentation and tests
  • The white-space formatting and imports have also changed. To make it easier to see the actual changes in a diff, and later for tracking modifications, it would be great if you can restore the original import order and whitespace as much as possible.
@spacanowski
Contributor

Changes done.
I left removing of leading and only in line whitespaces (easier to read when you have whitespace showing turned on in IDE).
Method getTypeArgumentsCount (fixed typo) is required for raw collections (without specified generics).

@rzwitserloot rzwitserloot merged commit 22e1fb9 into rzwitserloot:master Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment