New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015 CPAN PR Challenge - PR #1 - Tidy Branch #5

Merged
merged 21 commits into from Jan 30, 2015

Conversation

Projects
None yet
2 participants
@bambams
Contributor

bambams commented Jan 30, 2015

Kind of cutting it close here. Well I didn't accomplish a lot, but hopefully it helps a little. I ran out of time before I got anything more done. I'm submitting my changes in pieces so that you can pick and choose what you like and don't like. Many of these changes are superficial and subjective.

This first pull request is my "tidy" branch. It is intended just to clean up the code a little bit. Feel welcome to disagree with any of these changes. It's your module and your code and you ultimately have to be the one that likes it. :)

It may well be easier to merge this branch last since it may be less likely to conflict in that order. No guarantees though. You can experiment with what works. If you have any trouble merging please contact me. I would be more than happy to rebase. Thanks!

s-aska added a commit that referenced this pull request Jan 30, 2015

Merge pull request #5 from bambams/tidy
2015 CPAN PR Challenge - PR #1 - Tidy Branch

@s-aska s-aska merged commit b467c08 into s-aska:master Jan 30, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bambams bambams deleted the bambams:tidy branch Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment