New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015 CPAN PR Challenge - PR #2 - Use HTTP::Status instead of hard-coding numbers. #7

Merged
merged 22 commits into from Jan 30, 2015

Conversation

Projects
None yet
2 participants
@bambams
Contributor

bambams commented Jan 30, 2015

This is a very short branch that I have rebased onto my tidy branch. There should only be one commit to merge from this pull request! The only changes that it introduces are replacing hard-coded HTTP status codes with HTTP::Status constants. I'm not sure if this makes things better or worse, which is why it's in a separate branch from the tidy branch. It might not be worth an additional dependency (Http::Status), and it probably doesn't make things all that much more clear. I'm not even sure if the status names are standardized or not.

If you do decide to merge this branch you should do it after the tidy branch because I have rebased it onto my tidy branch. If you have any trouble merging I'd be happy to rebase it for you. Just contact me! Thanks.

@s-aska

This comment has been minimized.

Show comment
Hide comment
@s-aska

s-aska Jan 30, 2015

Owner

687474703a2f2f7265706c796769662e6e65742f692f3337352e676966
great!!

Owner

s-aska commented Jan 30, 2015

687474703a2f2f7265706c796769662e6e65742f692f3337352e676966
great!!

s-aska added a commit that referenced this pull request Jan 30, 2015

Merge pull request #7 from bambams/http-status
2015 CPAN PR Challenge - PR #2 - Use HTTP::Status instead of hard-coding numbers.

@s-aska s-aska merged commit 910aaa5 into s-aska:master Jan 30, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bambams bambams deleted the bambams:http-status branch Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment