New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Add <input> back to <form>... #8

Merged
merged 1 commit into from Jan 31, 2015

Conversation

Projects
None yet
2 participants
@bambams
Contributor

bambams commented Jan 31, 2015

My tidying up apparently led to a regression that removed the injected
<input> from <form> tags.

Doh! Evidently this module needs many more tests. :) Ironically it was
my HTML test program that detected this... Perhaps I can work on adding
additional tests in the future. Sorry for the confusion and trouble! I
can't believe I missed this. I'm actually sure that I caught this
earlier, but it must have gotten lost in rebasing or something... Who
knows.

Append: It appears that GitHub doesn't escape HTML... That seems... <script type="text/javascript">alert("VERY VERY BAD?");</script> bad. Instead they seem to strip it out (so you can't see the <script> tag that I attempted to inject before this sentence). I guess there's nothing to fear, but it seems pretty damn incompetent. Like Microsoft quality...

Fix regression: Add <input> back to <form>...
My tidying up apparently led to a regression that removed the injected
<input> from <form> tags.

Doh! Evidently this module needs many more tests. :) Ironically it was
my HTML test program that detected this... Perhaps I can work on adding
additional tests in the future. Sorry for the confusion and trouble! I
can't believe I missed this. I'm actually sure that I caught this
earlier, but it must have gotten lost in rebasing or something... Who
knows.
@bambams

This comment has been minimized.

Show comment
Hide comment
@bambams

bambams Jan 31, 2015

Contributor

For reference, the offending commit was fe608a6.

Contributor

bambams commented Jan 31, 2015

For reference, the offending commit was fe608a6.

s-aska added a commit that referenced this pull request Jan 31, 2015

Merge pull request #8 from bambams/tidy-fix
Fix regression: Add <input> back to <form>...

@s-aska s-aska merged commit 28574fc into s-aska:master Jan 31, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bambams bambams deleted the bambams:tidy-fix branch Jan 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment