Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing rename on file system #109

Merged
merged 5 commits into from Nov 25, 2015
Merged

Exposing rename on file system #109

merged 5 commits into from Nov 25, 2015

Conversation

coltonmercurio
Copy link
Contributor

No description provided.

s-macke added a commit that referenced this pull request Nov 25, 2015
Exposing rename on file system
@s-macke s-macke merged commit 2394e32 into s-macke:master Nov 25, 2015
@s-macke
Copy link
Owner

s-macke commented Nov 25, 2015

Thanks, looks good. May I ask you about the goal of these changes? Do you want to add a filesystem browser?

@coltonmercurio
Copy link
Contributor Author

Yes sir, we are working on the cs-education/sysbuild to add a project explorer and a persistent file system based on the local storage.

@coltonmercurio
Copy link
Contributor Author

Also I we've unintentionally merged commits that shouldn't be merged.
The only files that should have been commited are the two filesystem.js files.

I apologize for that.

@s-macke
Copy link
Owner

s-macke commented Nov 26, 2015

Cool. I hope you will manage it.
When you add more message commands you might want to set "fs." (for example "fs.rename") or something similar in front of all filesystem commands.

neelabhg added a commit to cs-education/jor1k that referenced this pull request Dec 9, 2015
Some unintentional changes were introduced when s-macke#109 was merged (see
s-macke#109 (comment)).

This commit reverts commit cb30ffc
("Merge pull request cmercur2/jor1k#2 from jjang16/master"),
reversing changes made to 45cedee
("adding rename to filesystem").

In particular:
* The compile script outputs into the demos folder again (instead of
  bin/)
* The compile script does not create the "sys" symlink anymore
* The "sys" submodule has been restored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants