Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serde to 1.x.y #27

Closed
wants to merge 2 commits into from
Closed

Update serde to 1.x.y #27

wants to merge 2 commits into from

Conversation

korczis
Copy link

@korczis korczis commented Nov 7, 2017

I am opening this PR to open discussion about plans to migrate to serde 1.x.y

@GitCop
Copy link

GitCop commented Nov 7, 2017

There were the following issues with your Pull Request

  • Commit: f15c2fc

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Commit: 7f30540

  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/rustless/valico/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@emk
Copy link

emk commented Dec 15, 2017

@korczis I could also use a version of valico that worked with stable serde.

emk added a commit to emk/compose_yml that referenced this pull request Dec 15, 2017
Notes:

- `valico` is not currently usable without extra hacks.  See
  #11 and
  s-panferov/valico#27
- `regex` has some API changes.
- `serde` has massive API changes.
- `error-chain` isn't worth the trouble of updating; we'll just switch
  over to `failure` sometime soon.

CC @seamusabshere @camjackson
@emk
Copy link

emk commented Dec 17, 2017

@korczis @camjackson @s-panferov

Hello! I'm the principal author of compose_yml and cage, two Docker-related development tools that rely on valico. We've been very happy with valico for schema validation!

Recently, I updated both tools to use serde 1.0. Unfortunately, this meant that I had to disable valico, which caused a couple of fairly major regressions in compose_yml and cage. I would love to get back valico's great validation support.

Is there anything I could do to help get this PR merged (and the corresponding changes to jsonway at korczis/jsonway@8a142a0)? I'd be happy to devote some engineering time to this.

Also, this would have the advantage of leaving valico in a stable state for the long term, because serde 1.0 is likely to stick around indefinitely. Also, it would be possible to re-export serde_json as valico::serde_json, which would allow valico to keep working even if serde 2.0 is released some day.

Thank you very much for valico, and for considering this PR! Please let me know if there's anything at all that I can to smooth the merging process.

@JordiPolo
Copy link

Really interested on this also, @korczis any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants