Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#define debug true messes with async wifimanager #17

Closed
wvdv2002 opened this issue Jun 25, 2018 · 1 comment · Fixed by #20
Closed

#define debug true messes with async wifimanager #17

wvdv2002 opened this issue Jun 25, 2018 · 1 comment · Fixed by #20
Assignees
@s00500

Comments

@wvdv2002
Copy link
Contributor

A nice addition to ESPUI is the ASYNC wifimanager project . Sadly fresh out of the box ESPUI and the wifi manager don't compile together because of the way debugging is handled, the "#define debug true" statement in the code. Maybe change it into something better defined and with capitals #define DEBUG_ESPUI or something.
@tx73github tx73github mentioned this issue Jun 27, 2018
Closed
@s00500
Copy link
Owner

s00500 commented Jun 27, 2018

Alright, this can be done =D

@s00500 s00500 self-assigned this Jun 27, 2018
@wvdv2002 wvdv2002 mentioned this issue Jul 3, 2018
Merged
@s00500 s00500 closed this as completed in #20 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s00500 s00500

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored debug define into DEBUG_ESPUI wvdv2002/ESPUI
2 participants
@wvdv2002 @s00500