Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use * in deps #1

Merged
merged 1 commit into from Apr 28, 2016
Merged

Use * in deps #1

merged 1 commit into from Apr 28, 2016

Conversation

kossnocorp
Copy link
Contributor

Newest npm doesn't like empty versions, we need to use * instead.

Newest npm doesn't like empty versions, we need to use * instead
@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@kossnocorp LGTM.

@s0ber s0ber merged commit 1bb5597 into s0ber:master Apr 28, 2016
@kossnocorp kossnocorp deleted the patch-1 branch April 28, 2016 09:18
@conf
Copy link

conf commented Apr 28, 2016

Shouldn't this be released as a new version?

@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@conf Yeah, seems like. I'll do it today.

@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@conf I've published it as a new version in npm.

@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@conf @kossnocorp I hope it won't break anything :)

@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@kossnocorp @conf Btw, we may even not need this thing now, because AFAIK we are not using javascript from gems anymore.

@s0ber
Copy link
Owner

s0ber commented Apr 28, 2016

@kossnocorp @conf Yeap, @paraboom confirmed that we don't need this package anymore.

@kossnocorp
Copy link
Contributor Author

@s0ber ok, great, we'll clean it up.

@conf
Copy link

conf commented Apr 28, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants