Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REXX: SIGNAL ON FAILURE isn't working (Not recognized). #88

Open
BertramMoshier opened this issue Jan 3, 2023 · 5 comments
Open

REXX: SIGNAL ON FAILURE isn't working (Not recognized). #88

BertramMoshier opened this issue Jan 3, 2023 · 5 comments
Labels
fixed in next release Staged in the next release candidate system

Comments

@BertramMoshier
Copy link

My REXX program template (which I just uploaded) does:

/------------------------
| Enable trap processing |
*------------------------*/
SIGNAL ON ERROR
SIGNAL ON FAILURE
SIGNAL ON HALT
SIGNAL ON NOVALUE
SIGNAL ON SYNTAX

I found REXX on VM/CE isn't supporting SIGNAL ON FAILURE

When REXX hits the statement SIGNAL ON FAILURE the following appears as the error:

template exec
29 - SIGNAL ON FAILURE
Error 25.3 running template, line 29: SIGNAL ON must be followed by one of the keywords ERROR, HALT, NOVALUE, NOTREADY or SYNTAX;
found "FAILURE"
Ready(20025); T=0.16/0.20 11:17:41

@BobBolch
Copy link
Collaborator

BobBolch commented Jan 3, 2023

SIGNAL ON FAILURE was added to REXX in VM/SP Release 6, after REXX had been available on VM for about 5 years.
It was never implemented in BREXX. This feature will be added to VMCE. FAILURE will be signaled when executing a CMS command (including the CMS CP command) produces a negative return code.

@BobBolch
Copy link
Collaborator

BobBolch commented Jan 4, 2023

It looks like SIGNAL ON ERROR doesn't work correctly either. It is not being signaled when a CMS command gets a non-zero RC.

========================
/* */
ADDRESS ''

SIGNAL ON ERROR

'ACCESS 333 Z'
EXIT RC

ERROR: SAY 'ERROR SIGNALLED'

Currently returns:
test2
DMSACC113S 'Z (333) ' NOT ATTACHED
Ready(00100); T=0.02/0.02 10:03:18

Should return:
test2
DMSACC113S 'Z (333) ' NOT ATTACHED
6 - 'ACCESS 333 Z'
+++ RC(100) +++
ERROR signalled
Ready(00016); T=0.02/0.02 10:03:05

@BobBolch
Copy link
Collaborator

Down load a test fix from https://www.dropbox.com/s/xrbt2nlcv2958aj/brexxfix.aws?dl=0

This is an aws tape made with a TAPE DUMP BREXX TEXT command.
Retrieve the test aws file, and use TAPE LOAD to create a BREXX TEXT file.
IPL CMS, so that the new BREXX TEXT file will be loaded, then test with a SIGNAL ON FAULRE sequence.

@BobBolch BobBolch added the fixed in next release Staged in the next release candidate system label Jan 16, 2023
@RossPatterson
Copy link
Collaborator

I don't know how Bob Bolch intended to fix this, and his Dropbox link is now dead, but I've written a fix of my own and sent a pull request to the main source tree.

@BertramMoshier
Copy link
Author

BertramMoshier commented Jun 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next release Staged in the next release candidate system
Projects
None yet
Development

No branches or pull requests

3 participants