Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

exit with error if put is passed nonexistant local file #65

Closed
meonkeys opened this Issue Jun 26, 2012 · 3 comments

Comments

Projects
None yet
2 participants

If file x does not exist locally, s3cmd put x s3://bucket prints no errors and returns a successful exit status (0).

Member

mdomsch commented Mar 9, 2013

This is more structural. None of the subcommands return their own exit status, to be propagated to the shell exit status. If one of the subcommands raises an S3Error, then the whole program exits with value 1. To resolve this would require changing each of the subcommands to return their own (meaningful) exit value, and propagate that to the sys.exit().

Member

mdomsch commented May 8, 2014

https://github.com/mdomsch/s3cmd/tree/bug/exitcodes
has a stab at adding proper exit codes to s3cmd. This attempts to address bug #19, #65, and #219 from a systematic POV.

If you hate using s3cmd because is almost always returned exit code 0 regardless, please take a look at this (short) branch and comment.

Thanks,
Matt

This was referenced May 8, 2014

Member

mdomsch commented May 9, 2014

pushed to master branch now. Please try and comment.

@mdomsch mdomsch closed this May 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment