Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix single file sync local2remote traceback, bug #128 #129

Merged
merged 1 commit into from

3 participants

@mdomsch
Owner

Fixes #128

In the single file transfer case, the remote_list was getting created
as a dict, rather than as a SortedDict as it should be.

@mdomsch mdomsch fix single file sync local2remote traceback, bug #128
Fixes s3tools#128

In the single file transfer case, the remote_list was getting created
as a dict, rather than as a SortedDict as it should be.
5631c00
@richardharrington

Wow, that was quick!

@mludvig
Owner

Whose idea was it to extend SortedDict() with all those MD5 functions?!
They should be in a separate class or in a class that inherits from SortedDict if must be. Oh well...

@mludvig mludvig merged commit ea21c77 into s3tools:master
@mdomsch
Owner

My bad - I didn't realize all the places SortedDict was used. See new pull request that splits that functionality out into a FileDict, derived from SortedDict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 5, 2013
  1. @mdomsch

    fix single file sync local2remote traceback, bug #128

    mdomsch authored mdomsch committed
    Fixes s3tools#128
    
    In the single file transfer case, the remote_list was getting created
    as a dict, rather than as a SortedDict as it should be.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  s3cmd
View
3  s3cmd
@@ -1058,7 +1058,8 @@ def cmd_sync_local2remote(args):
## Make remote_key same as local_key for comparison if we're dealing with only one file
remote_list_entry = remote_list[remote_list.keys()[0]]
# Flush remote_list, by the way
- remote_list = { local_list.keys()[0] : remote_list_entry }
+ remote_list = SortedDict()
+ remote_list[local_list.keys()[0]] = remote_list_entry
local_list, remote_list, update_list, copy_pairs = compare_filelists(local_list, remote_list, src_remote = False, dst_remote = True, delay_updates = cfg.delay_updates)
Something went wrong with that request. Please try again.