Fixing KeyError when copying multiple keys (SourceForge bug 3091912) #20

Merged
merged 1 commit into from Jan 7, 2012

Conversation

Projects
None yet
4 participants
Contributor

canadianveggie commented Jan 7, 2012

When you use 's3cmd cp' to copy multiple keys (without using the recursive flag) you get a Key Error.
s3cmd cp s3://source-bucket/prefix* s3://target-bucket

Logged here: http://sourceforge.net/tracker/?func=detail&aid=3091912&group_id=178907&atid=887015
and here: https://bugs.launchpad.net/ubuntu/+source/s3cmd/+bug/523586

Fixing bug 3091912 - KeyError when copying multiple keys
When you use 's3cmd cp' to copy multiple keys (without using the recursive flag) you get a Key Error.
s3cmd cp s3://source-bucket/prefix* s3://target-bucket

Logged here: http://sourceforge.net/tracker/?func=detail&aid=3091912&group_id=178907&atid=887015
and here: https://bugs.launchpad.net/ubuntu/+source/s3cmd/+bug/523586

mludvig added a commit that referenced this pull request Jan 7, 2012

Merge pull request #20 from pulseenergy/master
Fixing KeyError when copying multiple keys (SourceForge bug 3091912)

@mludvig mludvig merged commit f49ecb3 into s3tools:master Jan 7, 2012

Contributor

mludvig commented Jan 7, 2012

Thanks, merged now.

Michal

On 01/07/2012 08:35 PM, Christopher Porter wrote:

When you use 's3cmd cp' to copy multiple keys (without using the recursive flag) you get a Key Error.
s3cmd cp s3://source-bucket/prefix* s3://target-bucket

Logged here: http://sourceforge.net/tracker/?func=detail&aid=3091912&group_id=178907&atid=887015
and here: https://bugs.launchpad.net/ubuntu/+source/s3cmd/+bug/523586

You can merge this Pull Request by running:

git pull https://github.com/pulseenergy/s3cmd master

Or you can view, comment on it, or merge it online at:

#20

-- Commit Summary --

  • Fixing bug 3091912 - KeyError when copying multiple keys

-- File Changes --

M s3cmd (12)

-- Patch Links --

https://github.com/s3tools/s3cmd/pull/20.patch
https://github.com/s3tools/s3cmd/pull/20.diff


Reply to this email directly or view it on GitHub:
#20

This change breaks s3cmd on unix systems (Solaris SunOS 5.11). Please revert this

Member

mdomsch replied Apr 28, 2013

How so please?

/usr/bin/python doesn't exist on Solaris SunOS 5.11. python gets installed to /opt/local/bin/python

~] # which python
/opt/local/bin/python

Using /usr/bin/env allows env to choose the right path(s) to look for python, which makes the environment configurable for system administrators and development operations engineers and not tied down to one path and one path only.

Contributor

mludvig replied Apr 28, 2013

That's true it shouldn't have gone through. Reverted now. Thanks for the report Ryan

Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment