Follow symlinks, when requested. (Drop recursion detection) #23

Merged
merged 1 commit into from Feb 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

jbraeuer commented Jan 31, 2012

Recursion detection on symlinks was too restrictive. It would detect the following as recursion:

dir/
main-1234/
file1
file2
main -> main-1234

This is clearly not a recursion and a common pattern, eg when hosting package repositories.
Python's os.walk also does not do recursion detection. So lets behave like Python stdlib.

Remove recursion detection for symlinks.
Recursion detection on symlinks was too restrictive. It would detect the following as recursion:

dir/
    main-1234/
              file1
              file2
    main -> main-1234

This is clearly not a recursion and a common pattern, eg when hosting package repositories.
Python's os.walk also does not do recursion detection. So lets behave like Python stdlib.

Thanks for the contribution, looks good. Merging it now.

mludvig added a commit that referenced this pull request Feb 22, 2012

Merge pull request #23 from jbraeuer/master
Follow symlinks, when requested, drop recursion detection.

@mludvig mludvig merged commit add5f2b into s3tools:master Feb 22, 2012

Contributor

jbraeuer commented Feb 23, 2012

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment