New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #303 #304

Merged
merged 1 commit into from Mar 25, 2014

Conversation

Projects
None yet
2 participants
@alertedsnake
Contributor

alertedsnake commented Mar 25, 2014

Allows override of config file or EC2 IAM role credentials with the command-line, fixes the issue where command-line credentials were ignored if role credentials exist.

Fixes #303 - I'm not sure if this is the ideal fix or the preferred way, but it does the job.

Bugfix for my issue #303 - allows override of config file or EC2 IAM …
…role

credentials with the command-line, fixes the issue where command-line
credentials were ignored if role credentials exist.

mdomsch added a commit that referenced this pull request Mar 25, 2014

@mdomsch mdomsch merged commit 77db4c3 into s3tools:master Mar 25, 2014

@mdomsch

This comment has been minimized.

Show comment
Hide comment
@mdomsch

mdomsch Mar 25, 2014

Member

I think this makes sense. It initializes the Config() object if these are passed on the command line, which also overrides them if found in the config file.

Member

mdomsch commented Mar 25, 2014

I think this makes sense. It initializes the Config() object if these are passed on the command line, which also overrides them if found in the config file.

@alertedsnake alertedsnake deleted the alertedsnake:alertedsnake_bugfix_303 branch Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment