Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Handle empty return bodies when processing S3 errors. #32

Merged
merged 1 commit into from Mar 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

kellymclaughlin commented Feb 29, 2012

Currently error commands that do not return a body cause
s3cmd to output an ugly backtrace. This change checks to
see if the data field of the response is non-empty before
calling getTreeFromXml on it. An example of an offending
command is using s3cmd info on a nonexistent object.

Kelly McLaughlin Handle empty return bodies when processing S3 errors.
Currently error commands that do not return a body cause
s3cmd to output an ugly backtrace. This change checks to
see if the data field of the response is non-empty before
calling `getTreeFromXml` on it. An example of an offending
command is using `s3cmd info` on a nonexistent object.
a845140

@mludvig mludvig added a commit that referenced this pull request Mar 1, 2012

@mludvig mludvig Merge pull request #32 from kellymclaughlin/check-for-empty-error-res…
…ponse-body

Handle empty return bodies when processing S3 errors.
0151fa4

@mludvig mludvig merged commit 0151fa4 into s3tools:master Mar 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment