Add support for adding headers in .s3cfg file #41

Merged
merged 1 commit into from Feb 19, 2013

Conversation

Projects
None yet
6 participants
@relistan
Contributor

relistan commented Apr 1, 2012

Adding headers with --add-header from the command line is helpful But, it's sometimes nice to be able to set headers for all files in the .s3cfg. For example, to use AES256 encryption on all files uploaded. There are other places this is useful as well. It's a simple change that I think adds decent functionality to s3cmd. Here's how it looks in a config file:

[default]
add_headers = x-amz-server-side-encryption:AES256, x-foo:something

@gavinheavyside

This comment has been minimized.

Show comment
Hide comment
@gavinheavyside

gavinheavyside Apr 2, 2012

+1 This would be a massive help

+1 This would be a massive help

@relistan

This comment has been minimized.

Show comment
Hide comment
@relistan

relistan May 17, 2012

Contributor

Still would like to see this merged if you're willing.

Contributor

relistan commented May 17, 2012

Still would like to see this merged if you're willing.

@didip

This comment has been minimized.

Show comment
Hide comment
@didip

didip May 28, 2012

+1

didip commented May 28, 2012

+1

@mdomsch

This comment has been minimized.

Show comment
Hide comment
@mdomsch

mdomsch Jul 14, 2012

Member

I've pulled this (relistan/master) branch into a merge branch in my tree. Hopefully that'll help with an official upstream merge down the line...

Member

mdomsch commented Jul 14, 2012

I've pulled this (relistan/master) branch into a merge branch in my tree. Hopefully that'll help with an official upstream merge down the line...

@relistan

This comment has been minimized.

Show comment
Hide comment
@relistan

relistan Jul 18, 2012

Contributor

Great, thanks.

Contributor

relistan commented Jul 18, 2012

Great, thanks.

@relistan

This comment has been minimized.

Show comment
Hide comment
@relistan

relistan Jul 23, 2012

Contributor

I see that other pull requests have been merged since I opened this. Is there an objection to this request, or the implementation that is preventing this from getting pulled into master?

Contributor

relistan commented Jul 23, 2012

I see that other pull requests have been merged since I opened this. Is there an objection to this request, or the implementation that is preventing this from getting pulled into master?

@relistan

This comment has been minimized.

Show comment
Hide comment
@relistan

relistan Nov 22, 2012

Contributor

Anyone home? 8 months and counting!

Contributor

relistan commented Nov 22, 2012

Anyone home? 8 months and counting!

@hspencer77

This comment has been minimized.

Show comment
Hide comment
@hspencer77

hspencer77 Nov 23, 2012

There was an announcement a few weeks ago saying that the author was no longer
able to develop this tool. He was asking for volunteers to step in and take
over from him. I've not seen anything indicating that somebody has taken over
so I assume there is still a vacancy.

Hope this helps.

There was an announcement a few weeks ago saying that the author was no longer
able to develop this tool. He was asking for volunteers to step in and take
over from him. I've not seen anything indicating that somebody has taken over
so I assume there is still a vacancy.

Hope this helps.

@relistan

This comment has been minimized.

Show comment
Hide comment
@relistan

relistan Nov 24, 2012

Contributor

Ah, that explains why the pull request list has grown and grown recently. Thanks for the info, I missed that. I'll contact the author directly--hopefully he'll respond. Cheers.

Contributor

relistan commented Nov 24, 2012

Ah, that explains why the pull request list has grown and grown recently. Thanks for the info, I missed that. I'll contact the author directly--hopefully he'll respond. Cheers.

@hspencer77

This comment has been minimized.

Show comment
Hide comment
@hspencer77

hspencer77 Nov 24, 2012

If you end up wanting to lead the project, I don't mind helping. I don't have the cycles to take the lead on it, but I can help out a great deal. Let me know what you think.

Cheers.

If you end up wanting to lead the project, I don't mind helping. I don't have the cycles to take the lead on it, but I can help out a great deal. Let me know what you think.

Cheers.

@mludvig mludvig merged commit 50a4233 into s3tools:master Feb 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment