Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3: make relative imports explicit #806

Merged
merged 2 commits into from Dec 7, 2016
Merged

Python3: make relative imports explicit #806

merged 2 commits into from Dec 7, 2016

Conversation

@shaform
Copy link
Contributor

@shaform shaform commented Dec 7, 2016

Continue the effort for making it Python 3 compatible.
Some modules (Config, Utils, Progress) have cyclic dependency which makes it difficult to remove their implicit imports.
To keep this PR minimal, I do not attempt to resolve the above issue this time.

sys.exit(1)
else:
print "System encoding: " + encoding
print(("System encoding: " + encoding))

This comment has been minimized.

@fviard

fviard Dec 7, 2016
Contributor

Is it a typo the 2 parenthesis?

@@ -95,7 +97,7 @@ def is_exe(fpath):
#enc_base_remote = "%s/xyz/%s/" % (pbucket(1), encoding)
enc_pattern = patterns[encoding]
else:
print encoding + " specific files not found."
print((encoding + " specific files not found."))

This comment has been minimized.

@fviard

fviard Dec 7, 2016
Contributor

same a previous chunk, Is it a typo the 2 parenthesis?

@fviard
Copy link
Contributor

@fviard fviard commented Dec 7, 2016

If you can fix the 2 typos, (i think it is?), I will merge it right after as the rest looks good.

@shaform shaform force-pushed the shaform:py3k branch from 31f27aa to 35ee5d1 Dec 7, 2016
@shaform
Copy link
Contributor Author

@shaform shaform commented Dec 7, 2016

Thanks for the review. I've fixed them.

@fviard fviard merged commit 84a5b6c into s3tools:master Dec 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fviard
Copy link
Contributor

@fviard fviard commented Dec 7, 2016

Merged. Thanks.
By the way, if you can backport your changes of run-test-minio.py to run-test.py, that would be better for future as run-test.py is the official automatic full test that also cover aws specific things.

@shaform
Copy link
Contributor Author

@shaform shaform commented Dec 7, 2016

Surely. I think the only change that's not in run-test.py is cmd_args.insert(0, "python"). I'll make sure to include that in the next pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants