Prototype based #31
Merged
Prototype based #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use consistently use single quotes except where content includes double quotes
…ed arg (as per other patch); export class and deprecate exporting of singleton and class method (will probably allow for instance to avoid autostarting)
…ward compatibility. Having options first will allow separate calls for the object and expression to an evaluate method if autostarting is not desired
…method, "evaluate"
…s (clearer for readers of code)
…and deprecated syntaxes in docs; document properties and elaborate on syntax
…hes with sandbox-supplied vars; indicate object is private var.
…uiring "new" by avoided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on whitespace and JSLint changes, this PR moves to prototype-based inheritance in order to save on memory. It is backward compatible, though I have deprecated the old singleton style in favor of a class-based approach (I might still allow for a separate evaluate method but which would be auto-called by default for convenience and backward compatibility).
If the pseudo-privacy of the new underscored methods is a problem, we can simulate private instance methods by
.call(this, ...), but that has a run-time cost, and I don't think pseudo-privacy is any real problem.