Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix global leak of ret in JSONPath.normalize() #12

merged 1 commit into from Dec 11, 2012


None yet
3 participants

jonathana commented Oct 2, 2012

Fix global leak of ret in JSONPath.normalize().

While writing mocha tests around some use of JSONPath, it found a global declaration of ret in normalize() versus var. There appears to be no reason why ret would be a global in this context, and in other versions of the codebase--on google code--the value is just returned raw because there's no caching in place anyway.

Update lib/jsonpath.js
Fix global leak of ret in jsonPath.normalize()

Like #11 +1

s3u pushed a commit that referenced this pull request Dec 11, 2012

Merge pull request #12 from jonathana/master
Fix global leak of ret in JSONPath.normalize()

@s3u s3u merged commit d8a4b62 into s3u:master Dec 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment