Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CSRF token for comment deletion #439

Closed
garvinhicking opened this issue Jan 12, 2017 · 2 comments
Closed

Check CSRF token for comment deletion #439

garvinhicking opened this issue Jan 12, 2017 · 2 comments
Labels
bugs
Milestone
Minor

Comments

@garvinhicking
Copy link
Member

As reported by Lee Sheldon Victor: We need to utilize a comment token when calling serendipity_deleteComment (via comment.php) to protect against CSRF.
@garvinhicking garvinhicking added this to the 2.x.0 milestone Jan 12, 2017
@garvinhicking
Copy link
Member Author

Also check for CSRF token when installing a new event/sidebar plugin (thanks to Zhiyang Zeng)

@garvinhicking
Copy link
Member Author

Also check for CSRF token when disabling/enabling comments toggle

onli added a commit that referenced this issue Jan 17, 2017
@onli
Add multiple missing CSRF tokens (#439)
f947c66 
Deleting comments, disabling comment threads, installing plugins, toggling a spartacus update check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugs
Projects
None yet
Milestone
Minor
Development

No branches or pull requests
1 participant
@garvinhicking