Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Content Encoding Error" after posting comments #512

Open
th-h opened this issue May 13, 2017 · 1 comment

Comments

@th-h
Copy link
Member

commented May 13, 2017

See https://board.s9y.org/viewtopic.php?f=10&t=21200 (in German)
s9y 2.1.1, PHP 5.4.45-0+deb7u8, FF 53.0.2 (seems to be browser-independent)

After posting a comment, I get the following error message from my browser (and I can't view the entry that has been commented in any way, always getting that message):

Content Encoding Error The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.

After some time, the error message will disappear. If I log into the backend or log out from it, the error will disappear, too.

Older comments with mandatory moderation don't demonstrate this behaviour - as long as I'm not logged in. When logged in, the comment is not moderated and will appear immediately. That seems to trigger the bug.

Mari on the forums has traced the problem to serendipity_event_commentedit, see https://board.s9y.org/viewtopic.php?f=10&t=21223#p10447271 (in German). Disabling the plugin makes the error go away. This fits in with my observations: after 300 seconds (default), comment editing is disabled, so the bug disappears after some time. And logging in or out, I guess, will reset some cookie, so the plugin doesn't recognize me as the comment author and won't let me edit the comment, so the bug disappears, too.

Unfortunately I could not reproduce the problem on a (slim) test installation just with serendipity_event_commentedit installed. There seems to be an interdependency between two plugins.

@onli, you're listed as author of serendipity_event_commentedit. Perhaps you have any idea?

@th-h th-h changed the title "Content Encoding Error"a fter ps "Content Encoding Error" after posting comments May 13, 2017

@yellowled yellowled added this to the Patch milestone Jun 2, 2017

@onli

This comment has been minimized.

Copy link
Member

commented Jun 12, 2018

I think I know what the issue was. The plugin echoes some javascript above the html tag, the code from https://github.com/s9y/additional_plugins/blob/12aaee2e8fdf38d15ff8e97d82286603feae4239/serendipity_event_commentedit/serendipity_event_commentedit.php#L193. This does not lead to issues in my testblog, but I can assume that it would with some charset configuration.

The easiest solution here would be to either use a different hook - frontend_display called in serendipity_printComments should have access to the comment. Alternative, save in the fetchcomments which ids are relevant and output them sometime later, but that might be a bad idea.

@th-h th-h removed this from the Patch milestone Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.