New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML_RPC_Client has a deprecated constructor #532

Open
bauigel opened this Issue Sep 15, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@bauigel
Copy link

bauigel commented Sep 15, 2017

After a few month i tried to post an new article today and got following messages about deprecated features. Is this already fixed in current builds?

I'm running "Serendipity 2.2.0-beta1" and PHP 7.0.23, but i'm quiet sure my build is from a few days after last s9ycamp.

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; XML_RPC_Client has a deprecated constructor in .../bundled-libs/XML/RPC.php on line 597

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; XML_RPC_Response has a deprecated constructor in .../bundled-libs/XML/RPC.php on line 1046

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; XML_RPC_Message has a deprecated constructor in .../bundled-libs/XML/RPC.php on line 1138

Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; XML_RPC_Value has a deprecated constructor in .../bundled-libs/XML/RPC.php on line 1552

@onli

This comment has been minimized.

Copy link
Member

onli commented Sep 22, 2017

I thought those issues were all fixed :/. But no, https://github.com/s9y/Serendipity/blob/master/bundled-libs/XML/RPC.php still has those type of constructors. It probably got missed because it is not loaded without a specific plugin?

@onli onli added the bugs label Sep 22, 2017

@onli onli added this to the Minor milestone Sep 22, 2017

@onli onli added the blocking label Sep 22, 2017

@onli

This comment has been minimized.

Copy link
Member

onli commented Sep 13, 2018

@bauigel, can you debug this a bit more? Is that happening in combination with the xmlrpc-plugin only?

I assume that it could be replaced with https://github.com/gggeek/phpxmlrpc. But for that someone familiar with the functionality needs to sit down, do the port, and test it.

@onli

This comment has been minimized.

Copy link
Member

onli commented Feb 11, 2019

Honestly, I still do not know why you see those error messages but I don't. I now replaced the constructor, as that should remove the error. Could you test it out?

@onli onli removed the blocking label Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment