Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event_spartacus] Don't cache wrong plugin list. #619

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@th-h
Copy link
Member

th-h commented Aug 10, 2019

Declaring $pluginlist as static will cache the database query results and always return the same list of plugins - no matter which type is queried (sidebar or event).

This cache must be busted if another type of plugins is queried.

Signed-off-by: Thomas Hochstein thh@inter.net

Declaring $pluginlist as static will cache the
database query results and always return the same
list of plugins - no matter which type is queried
(sidebar or event).

This cache must be busted if another type of
plugins is queried.

Signed-off-by: Thomas Hochstein <thh@inter.net>
@th-h th-h referenced this pull request Aug 10, 2019
0 of 3 tasks complete
@th-h th-h merged commit f2e6fb7 into s9y:master Aug 10, 2019
@onli

This comment has been minimized.

Copy link
Member

onli commented Aug 10, 2019

How do you feel about using the serendipity cache functions instead of the static variable? To make the survive longer than one request cycle?

@th-h

This comment has been minimized.

Copy link
Member Author

th-h commented Aug 10, 2019

How do you feel about using the serendipity cache functions instead of the static variable? To make the survive longer than one request cycle?

I'm all for it, but have no idea how they work. :) I just improved on what I found ...

@th-h th-h deleted the th-h:thh-spartacus-fix-cache branch Aug 11, 2019
th-h added a commit to th-h/Serendipity that referenced this pull request Aug 16, 2019
Fixes s9y#619.

Signed-off-by: Thomas Hochstein <thh@inter.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.