Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior when your selecting all searched ones in list #176

Closed
AliBigdeli opened this issue Sep 1, 2022 · 4 comments
Closed

Wrong behavior when your selecting all searched ones in list #176

AliBigdeli opened this issue Sep 1, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@AliBigdeli
Copy link

I was trying to add a functionality with the default settings you already provided and there was one thing bothering me, when I have already a few selected ones in list and I start to search, there will be some results for example, as soon as I hit select all it will overwrite the existing selection instead of adding it and only visible ones are now selected and my older selected ones are gone.
i don't know if this is a bug or not but its awkward t do it like that.

this was my configuration:
VirtualSelect.init({
ele: '#job-title-list-filter',
options: job_title_options,
multiple: true,
search: true,
showSelectedOptionsFirst: true,
markSearchResults:true,
selectAllOnlyVisible:true,
});

pre-selected ones:
image

selected all the ones are visible
image

and now previous ones are gone

@sa-si-dev
Copy link
Owner

@AliBigdeli this is the expected behaviour as of now. I will find a way to handle your case and implement it.

@AliBigdeli
Copy link
Author

Thanks i appreciate it, and also thank you for the awsome module you provided 👍

@freddidierRTE
Copy link

linked with #151

@sa-si-dev sa-si-dev self-assigned this Sep 25, 2022
@sa-si-dev sa-si-dev added the enhancement New feature or request label Sep 25, 2022
@sa-si-dev
Copy link
Owner

@AliBigdeli this feature has been implemented in the release v1.0.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants