Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix events not removed when dropdown is destroyed #304

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Jan 26, 2024

This pull request fixes the issue of event listeners not being removed when the dropdown is destroyed and closes the issue #298.

image

@gnbm gnbm self-requested a review January 29, 2024 13:38
Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnbm gnbm merged commit f89ca5e into sa-si-dev:master Jan 29, 2024
@gnbm gnbm mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants