chore: add gitleaks baseline for audited false-positives#164
Conversation
Merge audited FP allowlist with existing repo config.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b0f19c296
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| '''(^|/)out/''', | ||
| '''(^|/)output/.*\.json$''', | ||
| '''(^|/)(README|QUICKSTART|CHANGELOG|CONTRIBUTING|DOCS?)\.(md|mdx)$''', | ||
| '''(^|/)docs?/''', |
There was a problem hiding this comment.
Because .github/workflows/git-hygiene.yml runs gitleaks on every PR and gitleaks global allowlist paths suppress matching findings, this broad docs?/ pattern makes any newly added real credential in docs/ or doc/ invisible to the secret-scanning gate. Documentation/runbook examples are a common place for accidentally pasted tokens, so this changes real-secret detection rather than only silencing audited false positives; prefer a fingerprint baseline or exact file/secret-pattern allowlist for the known findings.
Useful? React with 👍 / 👎.
| paths = [ | ||
| '''(^|/)docs/plans/current-remediation-plan\.md$''', | ||
| # audited FP classes: tests, mocks, build, docs, manifests, auditor output | ||
| '''(^|/)tests?/''', |
There was a problem hiding this comment.
This global test-path allowlist suppresses every gitleaks finding under test/ or tests/, so a developer who accidentally commits a live API key in an integration test fixture would still pass the PR secret-scanning workflow. That is broader than an audited false-positive baseline and removes protection from an entire class of committed source files; use exact fixture paths or .gitleaksignore fingerprints for the specific known test tokens instead.
Useful? React with 👍 / 👎.
1 participant
Adds a .gitleaks.toml baseline silencing 25 audited false-positives from the 2026-06-07 portfolio secret scan (test fixtures, mocks, build artifacts, doc curl examples, auditor output JSON). Extends the default ruleset — real-secret detection unchanged. Verified: gitleaks reports 0 findings with this config across all affected repos.