cleanup-service

[Dreick-dev]

I'm not sure but is the cleanup-service intended to get activated by hand? There is no hint do do so at installation, as far as I remember. Today I tried to figure out why my root-partition got bigger and bigger and analyzed it with filelight. This is what i got:

When I looked into named modules directory I saw what it was:

I looked into this repo and saw, that a system-service was intended to cleanup on startup. I looked for it, and saw, that it was not enabled. I triggered it by hand and of course, it took an eternity to copy - delete - copy -delete... and finally delete all copied directories.

Am I the only one who took that long to notice that? Either way, maybe it would be cool if the PKGBUILD could echo a hint to the console to activate the service.

Not a high-priority thing, but maybe a funny story and a suggestion.

[saber-nyan]

It seems that the file kernel-modules-hook.install was not added to the community repo when the package was added, so users do not see request to enable the systemd service linux-modules-cleanup.

kernel-modules-hook/kernel-modules-hook.install

Lines 1 to 16 in d5bb3c3

	post_install() {
	cat << EOF
	Please execute
	$ sudo systemctl daemon-reload
	$ sudo systemctl enable linux-modules-cleanup
	Report any issues to:
	https://github.com/saber-nyan/kernel-modules-hook/issues
	~desu
	EOF
	}

@shibumi is it possible to enable this service when installing the package or to notify the user to enable it?

[thurstylark]

FWIW, the daemon-reload instruction is superfluous in light of the systemd-daemon-reload hook that's shipped with the systemd package.

But otherwise, yes, the package as it exists in community currently lacks a notification that enabling the cleanup service is necessary for the advertised cleanup functionality to ...function.

I doubt that enabling or starting the systemd unit on install will be possible, as that's usually considered a user's choice to make, but it might be possible to get an install script notification added to the package.

I've created a feature request with downstream to float this idea, so we'll see how that goes: https://bugs.archlinux.org/task/74592

[C0rn3j]

@saber-nyan Please also add the instructions to the README

https://github.com/saber-nyan/kernel-modules-hook#installation