Making a wrong right again #409

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet

tobi commented Feb 22, 2012

Context: ShopQI is a Chinese clone of Shopify. I went ahead and improved it.

👍 LGTM

:shipit: ship it

jaehess commented Feb 22, 2012

+1

Fuck it, I'd fund that.

duff commented Feb 22, 2012

+1

+∞

edward commented Feb 22, 2012

@tobi no tests?

+1

burke commented Feb 22, 2012

👍

+1

sgonyea commented Feb 22, 2012

Because China.

@ghost

ghost commented Feb 22, 2012

so... what's plan b again?

JamieS commented Feb 22, 2012

Definitely an improvement!

Soleone commented Feb 22, 2012

  • 0 additions
  • 96,287 deletions

These are the best types of commits. 👏

(╯°□°)╯︵ ┻━┻

best pull request ever :)

Go for it!

masom commented Feb 22, 2012

+1

jdan commented Feb 22, 2012

+1

Kingfox commented Feb 22, 2012

+1

+1000 Internets!

++++1

danielw commented Feb 22, 2012

I approve of this pull request

Please resubmit with tests

dashed commented Feb 22, 2012

Hi Reddit.

So, it certainly appears (from the reports I've read; I've not gone and compared it myself yet) that ShopQi ripped off lots of publicly visible frontend code from Shopify. However, @tobi's merge also backs out all of the backend code. Presumably ShopQi had to write that bit themselves.

Also, it's kind of surprising that ShopQi pushed its entire source tree here on Github to begin with.

The code quality of this commit is amazing, it has gone up maybe 100%.

Best. Commit. Ever.

loadx commented Feb 22, 2012

+1

Brilliant! I love Shopify even more now!!

Beautiful

abronte commented Feb 22, 2012

+1

simond commented Feb 23, 2012

at least its open source. is shoppify?

raggi commented Feb 23, 2012

Wondering if @tobi is aware his assets and code were also relicensed under AGPL 3!

Ripoff? The guy at least had to write the backend, no? Seems to me that @tobi doesn't like competition. How about you do the same thing on the Diaspora repo and claim they are a Facebook ripoff?

-1

@lenage This is just a statement from @tobi that it's not ok to blatantly copy another person/companies work.

Competition is one thing, a total ripoff is another.

datl commented Feb 23, 2012

+1 I saw this on trending repos =)

@ghost

ghost commented Feb 23, 2012

Props to anyone that could build a product end to end. Nothing is original on the internets. Shopify should offer this guy a job to spearhead the Chinese market instead of belittling him.

geeknam commented Feb 23, 2012

I approve this pull request 👍

ilake commented Feb 23, 2012

+1 XD

So awesome.

+1 👍

hisea commented Mar 8, 2012

  1. Ripping off design is wrong.
  2. Removing the entire open source project including its original parts that are not ripoffs is also wrong.
  3. Correct a wrong with another wrong doesn't make anything right.

rgurley commented Mar 8, 2012

Ripping off design is wrong.

O RLY?

http://www.youtube.com/watch?v=zL2FOrx41N0

hisea commented Mar 9, 2012

@rgurley
hmm. .interesting video.

wjp2013 commented Apr 4, 2012

+1

pbc commented Jul 23, 2012

+1

Nicely played.

@saberma saberma closed this Jan 21, 2013

Nice refactor! 👍

Awesome! 🚢

Test failures legit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment