Skip to content
This repository

Making a wrong right again #409

Closed
wants to merge 1 commit into from
Tobias Lütke

Context: ShopQI is a Chinese clone of Shopify. I went ahead and improved it.

Harry Brundage

:+1: LGTM

Daniel Beauchamp

:shipit: ship it

Jae Hess

+1

Pete Forde

Fuck it, I'd fund that.

Duff OMelia

+1

Joshua Gosse

+∞

Edward Ocampo-Gooding

@tobi no tests?

Scott Gonyea

Because China.

Deleted user

The content you are editing has changed. Reload the page and try again.

so... what's plan b again?

Sending Request…

Attach images by dragging & dropping or selecting them. Octocat-spinner-32 Uploading your images… Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG. Yowza, that's a big file. Try again with an image file smaller than 10MB. This browser doesn't support image attachments. We recommend updating to the latest Internet Explorer, Google Chrome, or Firefox. Something went really wrong, and we can't process that image. Try again.

Jamie

Definitely an improvement!

Dennis Theisen
  • 0 additions
  • 96,287 deletions

These are the best types of commits. :clap:

Caroline

(╯°□°)╯︵ ┻━┻

David T

best pull request ever :)

buffpojken

Go for it!

Martin Samson

+1

Jordan Scales

+1

Russell Sprague

+1

Mike Hostetler

+1000 Internets!

Colin McDonald

++++1

Daniel Weinand

I approve of this pull request

David Celis

Please resubmit with tests

Alberto Leal

Hi Reddit.

Andrew Clunis

So, it certainly appears (from the reports I've read; I've not gone and compared it myself yet) that ShopQi ripped off lots of publicly visible frontend code from Shopify. However, @tobi's merge also backs out all of the backend code. Presumably ShopQi had to write that bit themselves.

Also, it's kind of surprising that ShopQi pushed its entire source tree here on Github to begin with.

Andrea Faulds

The code quality of this commit is amazing, it has gone up maybe 100%.

Laurelai

Best. Commit. Ever.

Mat Brennan

+1

Chris Mousdale

Brilliant! I love Shopify even more now!!

Ben Wiseley

Beautiful

Adam Bronte

+1

simond

at least its open source. is shoppify?

James Tucker

Wondering if @tobi is aware his assets and code were also relicensed under AGPL 3!

Olivier Lalonde

Ripoff? The guy at least had to write the backend, no? Seems to me that @tobi doesn't like competition. How about you do the same thing on the Diaspora repo and claim they are a Facebook ripoff?

-1

Adam McKerlie

@lenage This is just a statement from @tobi that it's not ok to blatantly copy another person/companies work.

Competition is one thing, a total ripoff is another.

Dat Le

+1 I saw this on trending repos =)

Zee Yang

Props to anyone that could build a product end to end. Nothing is original on the internets. Shopify should offer this guy a job to spearhead the Chinese market instead of belittling him.

Nam Ngo

I approve this pull request :+1:

ilake

+1 XD

Chris Stringer

So awesome.

Mason Stewart

+1 :thumbsup:

Yinghai Zhao
hisea commented March 07, 2012
  1. Ripping off design is wrong.
  2. Removing the entire open source project including its original parts that are not ripoffs is also wrong.
  3. Correct a wrong with another wrong doesn't make anything right.
Ramsey Gurley

Ripping off design is wrong.

O RLY?

http://www.youtube.com/watch?v=zL2FOrx41N0

Yinghai Zhao
hisea commented March 08, 2012

@rgurley
hmm. .interesting video.

Victor Wang

+1

Pawel Barcik
pbc commented July 23, 2012

+1

Luke Melia

Nicely played.

saberma closed this January 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Feb 22, 2012
Tobias Lütke made the internet better 5db65d1
Something went wrong with that request. Please try again.