Skip to content

Making a wrong right again #409

Closed
wants to merge 1 commit into from
@tobi
tobi commented Feb 22, 2012

Context: ShopQI is a Chinese clone of Shopify. I went ahead and improved it.

@airhorns

:+1: LGTM

@pushmatrix

:shipit: ship it

@jaehess
jaehess commented Feb 22, 2012

+1

@peteforde

Fuck it, I'd fund that.

@romanlehnert

+1

@duff
duff commented Feb 22, 2012

+1

@joshgosse

+∞

@silent1mezzo

+1

@edward
edward commented Feb 22, 2012

@tobi no tests?

@EricHogue

+1

@burke
burke commented Feb 22, 2012

:+1:

@matthelm

+1

@sgonyea
sgonyea commented Feb 22, 2012

Because China.

@iamwilhelm

+1

@ghost
ghost commented Feb 22, 2012

so... what's plan b again?

@JamieS
JamieS commented Feb 22, 2012

Definitely an improvement!

@mattroberts

+1

@Soleone
Soleone commented Feb 22, 2012
  • 0 additions
  • 96,287 deletions

These are the best types of commits. :clap:

@carolineschnapp

(╯°□°)╯︵ ┻━┻

@DavidToca

best pull request ever :)

@buffpojken

Go for it!

@masom
masom commented Feb 22, 2012

+1

@jdan
jdan commented Feb 22, 2012

+1

@Kingfox
Kingfox commented Feb 22, 2012

+1

@mikehostetler

+1000 Internets!

@cmcdonaldca

++++1

@danielw
danielw commented Feb 22, 2012

I approve of this pull request

@ryanlanglois

lol

@davidcelis

Please resubmit with tests

@dashed
dashed commented Feb 22, 2012

Hi Reddit.

@orospakr

So, it certainly appears (from the reports I've read; I've not gone and compared it myself yet) that ShopQi ripped off lots of publicly visible frontend code from Shopify. However, @tobi's merge also backs out all of the backend code. Presumably ShopQi had to write that bit themselves.

Also, it's kind of surprising that ShopQi pushed its entire source tree here on Github to begin with.

@TazeTSchnitzel

The code quality of this commit is amazing, it has gone up maybe 100%.

@Laurelai

Best. Commit. Ever.

@loadx
loadx commented Feb 22, 2012

+1

@Chrisedmo

Brilliant! I love Shopify even more now!!

@wiseleyb

Beautiful

@abronte
abronte commented Feb 22, 2012

+1

@simond
simond commented Feb 23, 2012

at least its open source. is shoppify?

@raggi
raggi commented Feb 23, 2012

Wondering if @tobi is aware his assets and code were also relicensed under AGPL 3!

@olalonde

Ripoff? The guy at least had to write the backend, no? Seems to me that @tobi doesn't like competition. How about you do the same thing on the Diaspora repo and claim they are a Facebook ripoff?

-1

@silent1mezzo

@lenage This is just a statement from @tobi that it's not ok to blatantly copy another person/companies work.

Competition is one thing, a total ripoff is another.

@datl
datl commented Feb 23, 2012

+1 I saw this on trending repos =)

@ghost
ghost commented Feb 23, 2012

Props to anyone that could build a product end to end. Nothing is original on the internets. Shopify should offer this guy a job to spearhead the Chinese market instead of belittling him.

@geeknam
geeknam commented Feb 23, 2012

I approve this pull request :+1:

@ilake
ilake commented Feb 23, 2012

+1 XD

@jcstringer

So awesome.

@masondesu

+1 :thumbsup:

@hisea
hisea commented Mar 8, 2012
  1. Ripping off design is wrong.
  2. Removing the entire open source project including its original parts that are not ripoffs is also wrong.
  3. Correct a wrong with another wrong doesn't make anything right.
@rgurley
rgurley commented Mar 8, 2012

Ripping off design is wrong.

O RLY?

http://www.youtube.com/watch?v=zL2FOrx41N0

@hisea
hisea commented Mar 9, 2012

@rgurley
hmm. .interesting video.

@wjp2013
wjp2013 commented Apr 4, 2012

+1

@pbc
pbc commented Jul 23, 2012

+1

@lukemelia

Nicely played.

@saberma saberma closed this Jan 21, 2013
@arapehl
arapehl commented Oct 22, 2015

yolo shipit

@mac-adam-chaieb

Nice refactor! :+1:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.