From fbd467551eb4c9dd85219b027a2aee14af8df8e7 Mon Sep 17 00:00:00 2001 From: mattab Date: Thu, 19 Dec 2013 12:59:05 +1300 Subject: [PATCH] Refs #1640 Adding jshrink to LEGALNOTICE + update help text --- LEGALNOTICE | 4 ++++ core/AssetManager/UIAssetMinifier.php | 2 +- core/testMinimumPhpVersion.php | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/LEGALNOTICE b/LEGALNOTICE index f394df67e44..a2464aa0a1c 100644 --- a/LEGALNOTICE +++ b/LEGALNOTICE @@ -114,6 +114,10 @@ THIRD-PARTY COMPONENTS AND LIBRARIES Notes: - reference implementation + Name: jshrink + Link: https://github.com/tedivm/jshrink + License: BSD-3-Clause + Name: sparkline Link: https//sourceforge.net/projects/sparkline/ License: Dual-licensed: New BSD or GPL v2 diff --git a/core/AssetManager/UIAssetMinifier.php b/core/AssetManager/UIAssetMinifier.php index fe29f1ec61d..83705f7e9c8 100644 --- a/core/AssetManager/UIAssetMinifier.php +++ b/core/AssetManager/UIAssetMinifier.php @@ -62,6 +62,6 @@ public function minifyJs($content) private static function validateDependency() { if (!class_exists("JShrink\Minifier")) - throw new Exception("JShrink dependency is managed using Composer."); + throw new Exception("JShrink dependency is managed using Composer.
$ php composer.phar update "); } } diff --git a/core/testMinimumPhpVersion.php b/core/testMinimumPhpVersion.php index 90ccdd2d0fd..e7dd79fd043 100644 --- a/core/testMinimumPhpVersion.php +++ b/core/testMinimumPhpVersion.php @@ -53,7 +53,7 @@ . "
 curl -sS https://getcomposer.org/installer | php \n\n php composer.phar install\n\n
"; if (DIRECTORY_SEPARATOR === '\\' /* ::isWindows() */) { $composerInstall = "Download and run Composer-Setup.exe, it will install the latest Composer version and set up your PATH so that you can just call composer from any directory in your command line. " - . "
Then run this command in a terminal in the piwik directory:
$ php composer update "; + . "
Then run this command in a terminal in the piwik directory:
$ php composer.phar update "; } $piwik_errorMessage .= "

It appears the composer tool is not yet installed. You can install Composer in a few easy steps:\n\n". "
" . $composerInstall.