Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Traceback "ENGINE Error in HTTPServer.tick" with unaccepted SSL/TLS connections #820
SABnzb 1.2.1Beta1 / Python 2.7.12 / Ubuntu 16.10
TL;DR: SABnzbd gives a Traceback in case of a problem with an incoming SSL/TLS connection. I would prefer an informing log line.
Disclaimer: I'm assuming it's OK that SAB refuses these connections, but I'm not sure
As soon as testssl.sh starts testing SABnbzd's HTTPS, SABnzbd spits out a lot (200!) of Tracebacks SSL error messages. See below.
How relevant is this? This does happen too when normal HTTPS clients SABnzbd's HTTPS. See https://forums.sabnzbd.org/viewtopic.php?f=2&t=22369&p=110844 and maybe https://forums.sabnzbd.org/viewtopic.php?f=3&t=22425&p=110821 (different message)
I think the Tracebacks are too alarming. I think it would be better if there was just a informing message in sabnzbd.log (INFO or DEBUG)
The traceback on SAB's side is easy to reproduce:
NB: SABnzbd 1.2.1Beta1. NOT the new branch!!
Client side code:
FWIW: Tested with SABnzbd 1.1.1 and testssl.sh: server-side (=SABnzbd): 0 errors / messages.
(SABnzbd 1.2.0 gives the same error messages as SABnzbd 1.2.1Beta1)
BRB with the branch test.
FWIW: Statistics from sabnzbd.log after a few testssl.sh runs:
With the current git version of origin/1.2.x, while testing SAB with testssl.sh, SABnzbd's stdout says several times:
"unknown error" ... ? I added that to cherrypy/wsgiserver/ssl_builtin.py:
... and the SAB tracebacks are gone.
BUT ... is it OK to ignore 'unknown error'?