New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leading asterisks have wrong background color in terminal Emacs #16

Open
stefanavey opened this Issue Jan 28, 2016 · 13 comments

Comments

Projects
None yet
6 participants
@stefanavey

stefanavey commented Jan 28, 2016

I'm not sure if you intended this to be compatible with Emacs run from the terminal but I see the leading stars (even when I set the hidestars startup option for org mode) because they have a black background.

When I open the same file in the GUI Emacs I do not see this black background so the leading stars are hidden and it looks clean.

org-bullets

@fosskers

This comment has been minimized.

Show comment
Hide comment
@fosskers

fosskers Apr 17, 2016

I use emacs strictly out of the terminal, and yeah this doesn't look so great.

fosskers commented Apr 17, 2016

I use emacs strictly out of the terminal, and yeah this doesn't look so great.

@Kaligule

This comment has been minimized.

Show comment
Hide comment
@Kaligule

Kaligule Jul 23, 2016

This could help to determine if the buffer lives in a gui or in a textbased terminal.

Kaligule commented Jul 23, 2016

This could help to determine if the buffer lives in a gui or in a textbased terminal.

@evadnoob

This comment has been minimized.

Show comment
Hide comment
@evadnoob

evadnoob Feb 8, 2017

I use rxvt-unicode/urxvt and I have the same issue:

◉ This is a test of org-bullets mode
*○ two stars
**✸ three stars

evadnoob commented Feb 8, 2017

I use rxvt-unicode/urxvt and I have the same issue:

◉ This is a test of org-bullets mode
*○ two stars
**✸ three stars

@stefanavey

This comment has been minimized.

Show comment
Hide comment
@stefanavey

stefanavey Feb 10, 2017

I was able to solve my problem a while ago. I think it was solved by redefining the org-hide face. This now works in my terminal Emacs as well (you'll have to change the color depending on your background color).

         ;; Redefine a face from org-faces.el                                                                                                           
         (defface org-hide
           '((((background light)) (:foreground "color-231"))
             (((background dark)) (:foreground "black")))
           "Face used to hide leading stars in headlines.                                                                                               
           The foreground color of this face should be 
           equal to the background color of the frame."
           :group 'org-faces)

stefanavey commented Feb 10, 2017

I was able to solve my problem a while ago. I think it was solved by redefining the org-hide face. This now works in my terminal Emacs as well (you'll have to change the color depending on your background color).

         ;; Redefine a face from org-faces.el                                                                                                           
         (defface org-hide
           '((((background light)) (:foreground "color-231"))
             (((background dark)) (:foreground "black")))
           "Face used to hide leading stars in headlines.                                                                                               
           The foreground color of this face should be 
           equal to the background color of the frame."
           :group 'org-faces)

@stefanavey stefanavey closed this Feb 10, 2017

@Kaligule

This comment has been minimized.

Show comment
Hide comment
@Kaligule

Kaligule Feb 10, 2017

@stefanavey I don't think that this alone solved the problem, since org-bullets doesn't seem to respect the org-hide face at all. It doesn't work for me. Could you provide additional information or even you init file?

Kaligule commented Feb 10, 2017

@stefanavey I don't think that this alone solved the problem, since org-bullets doesn't seem to respect the org-hide face at all. It doesn't work for me. Could you provide additional information or even you init file?

@Kaligule

This comment has been minimized.

Show comment
Hide comment
@Kaligule

Kaligule Feb 10, 2017

I added a pullrequest so org-bullet does respect org-hide. Lets hope @sabof is still maintaing this repo.

Kaligule commented Feb 10, 2017

I added a pullrequest so org-bullet does respect org-hide. Lets hope @sabof is still maintaing this repo.

@Kaligule

This comment has been minimized.

Show comment
Hide comment
@Kaligule

Kaligule Feb 10, 2017

Btw making text invisible (so that it looks like like blank space) seems to be difficult and has been discussed here.

Kaligule commented Feb 10, 2017

Btw making text invisible (so that it looks like like blank space) seems to be difficult and has been discussed here.

@stefanavey

This comment has been minimized.

Show comment
Hide comment
@stefanavey

stefanavey Feb 13, 2017

@Kaligule you are right this alone won't fix it. I thought that was my fix but it's been a long time and I forgot I stopped using org-bullets (for this reason). Sorry for the confusion - I hope it gets fixed and I'd love to try it out again.

stefanavey commented Feb 13, 2017

@Kaligule you are right this alone won't fix it. I thought that was my fix but it's been a long time and I forgot I stopped using org-bullets (for this reason). Sorry for the confusion - I hope it gets fixed and I'd love to try it out again.

@stefanavey stefanavey reopened this Feb 13, 2017

@sus007

This comment has been minimized.

Show comment
Hide comment
@sus007

sus007 Jul 15, 2018

@stefanavey @fosskers @sabof @Kaligule Guys, any updates or fixes regarding this issue ? 😕
emacs

sus007 commented Jul 15, 2018

@stefanavey @fosskers @sabof @Kaligule Guys, any updates or fixes regarding this issue ? 😕
emacs

@fosskers

This comment has been minimized.

Show comment
Hide comment
@fosskers

fosskers Jul 15, 2018

@sus007 I switched to spacemacs about a year ago, where org-bullets works perfectly out of the box.

I usually use the GUI mode, but I tested it quickly in the terminal and I don't see this bullets problem there either.

fosskers commented Jul 15, 2018

@sus007 I switched to spacemacs about a year ago, where org-bullets works perfectly out of the box.

I usually use the GUI mode, but I tested it quickly in the terminal and I don't see this bullets problem there either.

@stefanavey

This comment has been minimized.

Show comment
Hide comment
@stefanavey

stefanavey Jul 15, 2018

@sus007 I'm back to using org-bullets and it works fine for me (even in terminal) when using a light theme. I can reproduce your screenshot using a dark theme (where the stars are "hidden" with correct face but have grey background). Haven't tried to fix it since I normally don't use a dark background but I'll look into it if I have time.

stefanavey commented Jul 15, 2018

@sus007 I'm back to using org-bullets and it works fine for me (even in terminal) when using a light theme. I can reproduce your screenshot using a dark theme (where the stars are "hidden" with correct face but have grey background). Haven't tried to fix it since I normally don't use a dark background but I'll look into it if I have time.

@sus007

This comment has been minimized.

Show comment
Hide comment
@sus007

sus007 Jul 16, 2018

@stefanavey I do use dark background and I had never tested an actual dark color scheme before with Emacs. I am ok with this for the time being. 😃 Thanks.
ema

sus007 commented Jul 16, 2018

@stefanavey I do use dark background and I had never tested an actual dark color scheme before with Emacs. I am ok with this for the time being. 😃 Thanks.
ema

@alphapapa

This comment has been minimized.

Show comment
Hide comment
@alphapapa

alphapapa Sep 4, 2018

@sus007 I haven't seen icons in place of to-do keywords before. Do you have a source for how you did that? :)

alphapapa commented Sep 4, 2018

@sus007 I haven't seen icons in place of to-do keywords before. Do you have a source for how you did that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment