Skip to content

Conversation

@kabojnk
Copy link

@kabojnk kabojnk commented Jun 16, 2014

This is a change I made to sabre-xml based on issue #6. It's a small fix--and I was using it internally--but I thought I might as well submit a pull request just in case anyone else wants to use it.

@evert
Copy link
Member

evert commented Jun 16, 2014

Thank you! I need to decide what I want to do with this.

It may be more appropriate to return '{}' . $this->localName instead of just $this->localName.
Will hopefully be able to dig into this soon again.

@kmasalski
Copy link

Do we really need '{}' . $this->localName to note that there is no namespace? I think $this->localName is just fine.

@evert
Copy link
Member

evert commented Sep 19, 2014

I think non-namespaces xml should be treated as an edge-case and generally a bad idea =)

@kabojnk
Copy link
Author

kabojnk commented Sep 22, 2014

Indeed, in an ideal world sense, it's a bad idea. ;)

Although in the real world we sometimes find ourselves with piles of non-namespaced xml. Still gotta process it regardless. ;)

@evert
Copy link
Member

evert commented Sep 22, 2014

Fair enough... I'm going to throw all this stuff around in a future release and start relying on prefixes.

That way you can just define a prefix for non-namespaced xml.

@evert
Copy link
Member

evert commented Sep 26, 2014

Using #13 instead of this patch.

@evert evert closed this Sep 26, 2014
@kabojnk
Copy link
Author

kabojnk commented Oct 2, 2014

Excellent. Thanks for adding this (or rather, #13)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants