Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Substantial MaterialSearcher performance improvement for importing maps #246

Merged
merged 1 commit into from Jun 13, 2020

Conversation

vesuvian
Copy link

@vesuvian vesuvian commented May 4, 2020

The MaterialSearcher was getting very slow if there were a lot of cache misses or a lot of materials in the map.

I've reworked it so it caches the available materials in a single pass, then works against the cache. The result is substantially faster.

@Henry00IS
Copy link
Collaborator

I was skeptical at first just how much of an improvement this change would give. The first time I tried this on a full HL2 map (with over 1GB of materials) I had to wait 25 seconds before the import processing began- but (in my chisel version) the level imported so fast that I could barely see the progress bar. Subsequent imports, even after Unity restarts, no longer had that initial delay making it as fast as loading a map in Hammer. Fantastic work @vesuvian! Thank you so much! 😁

@Henry00IS Henry00IS merged commit e27cda2 into sabresaurus:master Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants