Remove Mentions of turn-on-artbollocks-mode #2

Merged
merged 1 commit into from Jan 21, 2013

Conversation

Projects
None yet
2 participants
@ejmr
Contributor

ejmr commented Jan 19, 2013

That function is no longer part of artbollocks-mode but the documentation still recommends it as the function to use for hooks, which can cause some really weird problems (one of which is described in the commit message).

Eric James Michael Ritz
Remove all mention of turn-on-artbollocks-mode
This function is no longer part of artbollocks-mode but the README and
the usage documentation in the source code both show it as the
preferred way to enable artbollocks-mode as a hook for other modes.
Attempting to use turn-on-artbollocks-mode can cause some obscure
errors, such as breaking log-edit-show-diff.  The correct way to
enable artbollocks-mode is to simply setup hooks to call that function
directly, and this patch changes the documentation to reflect that.

Signed-off-by: Eric James Michael Ritz <lobbyjones@gmail.com>
@ejmr

This comment has been minimized.

Show comment Hide comment
@ejmr

ejmr Jan 19, 2013

Contributor

Oh that was stupid of me. I failed to notice my patch also changed some whitespace on other lines as well, as a side-effect of some hooks I have setup. I can fix that if you'd like to restrict the patch to only the relevant documentation changes.

Contributor

ejmr commented Jan 19, 2013

Oh that was stupid of me. I failed to notice my patch also changed some whitespace on other lines as well, as a side-effect of some hooks I have setup. I can fix that if you'd like to restrict the patch to only the relevant documentation changes.

sachac added a commit that referenced this pull request Jan 21, 2013

Merge pull request #2 from ejmr/ejmr/fix-usage-documentation
Remove Mentions of turn-on-artbollocks-mode

@sachac sachac merged commit 29f1fac into sachac:master Jan 21, 2013

@sachac

This comment has been minimized.

Show comment Hide comment
@sachac

sachac Jan 21, 2013

Owner

No worries. Thanks for the update! =D

Owner

sachac commented Jan 21, 2013

No worries. Thanks for the update! =D

@ejmr ejmr deleted the ejmr:ejmr/fix-usage-documentation branch Jan 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment