Feature/deal with swtch stmt #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matts966
commented
Mar 7, 2019
passes/erreq/erreq.go
Outdated
| @@ -50,7 +70,56 @@ func run(pass *analysis.Pass) (interface{}, error) { | |||
| return | |||
| } | |||
|
|
|||
| pass.Reportf(node.Pos(), "do not compare error with \"==\" or \"!=\"") | |||
There was a problem hiding this comment.
Tests didn't pass in my local environment maybe because the format of the report.
sachaos
requested changes
Mar 14, 2019
passes/erreq/erreq.go
Outdated
| var causeFuncs = []string{ | ||
| "TestCauseFunc", // For test | ||
|
|
||
| "github.com/pkg/errors.Cause", |
There was a problem hiding this comment.
I want to focus on xerrors only, in this project.
So please remove this one.
passes/erreq/erreq.go
Outdated
| var errType = types.Universe.Lookup("error").Type().Underlying().(*types.Interface) | ||
|
|
||
| var causeFuncs = []string{ | ||
| "TestCauseFunc", // For test |
There was a problem hiding this comment.
We can test with xerrors.Unwrap.
So please remove this one.
added 3 commits
March 19, 2019 08:28
sachaos
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1