Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort scan_directory file list #53

Closed
wants to merge 1 commit into from

Conversation

@bmwiedemann
Copy link

commented Jul 15, 2019

Sort scan_directory file list
so that xml_resource.cpp builds in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

Note: scandir(3) only works on POSIX-compliant systems like Linux, BSD and MacOSX
not MSWindows

This PR was done while working on reproducible builds for openSUSE.

Sort scan_directory file list
so that xml_resource.cpp builds in a reproducible way
in spite of indeterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.
@sadko4u

This comment has been minimized.

Copy link
Owner

commented Jul 15, 2019

As a solution for 1.1.9 build, it's OK.
I've merged the changes into the hotfix branch: 23724d9.
You may use this branch as source of patches for the master branch.
Because there are now more than XML resources that can be embedded, current development branch of the tool requires some redesign. I'll do it soon.

@sadko4u sadko4u added this to the 1.1.10 milestone Jul 15, 2019

@sadko4u

This comment has been minimized.

Copy link
Owner

commented Jul 15, 2019

The reproducible builds will be accessible in 1.1.10 release.

@sadko4u sadko4u closed this Jul 15, 2019

@bmwiedemann bmwiedemann deleted the bmwiedemann:scandir branch Jul 16, 2019

@sadko4u

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2019

Available in 1.1.10 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.