Sort scan_directory file list #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that xml_resource.cpp builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good.
|
As a solution for 1.1.9 build, it's OK. |
sadko4u
added
HOTFIX
|
The reproducible builds will be accessible in 1.1.10 release. |
sadko4u
added
the
PENDING FOR RELEASE
|
Available in 1.1.10 release! |
sadko4u
removed
HOTFIX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sort scan_directory file list
so that xml_resource.cpp builds in a reproducible way
in spite of indeterministic filesystem readdir order.
See https://reproducible-builds.org/ for why this is good.
Note: scandir(3) only works on POSIX-compliant systems like Linux, BSD and MacOSX
not MSWindows
This PR was done while working on reproducible builds for openSUSE.