New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make some simplicial complexes faster #13244
Comments
comment:2
The patch looks good, even if I am not quite convinced by the trading of time-consumption versus dataspace-usage. But where is the patchbot ? |
comment:3
Replying to @fchapoton:
My belief is that this is the better approach since memory/disk space is cheap, especially compared to CPU cycles since it takes seconds. However I would argue that each of these should be implemented as (immutable) singletons unless someone can think of a reason why you would need a true duplicate. Perhaps that should be another ticket and this one be set to positive review? Also a minor technical thing, from looking at the patch file I believe the reference in SimplicialComplexExamples() on line 1027 is missing the linking underscore. |
Attachment: trac_13244-simplicial.patch.gz |
comment:4
I added the missing underscore; thanks for catching that.
I certainly agree with this, but I wrote the patch.
I'm not sure what you mean by this. Do you mean that any two instances of |
comment:5
Replying to @jhpalmieri:
I think so. I think sage's
But I'm happy moving this to a later ticket. |
comment:6
Everything is looks good to me. I've created a ticket for the above #13566. |
Reviewer: Travis Scrimshaw |
Merged: sage-5.5.beta0 |
A few simplicial complexes in the file
sage/homology/examples.py
are defined by computing orbits of a some lists under the action of a specific group. This can take a second or two, so we can save time by doing the computations once and then just using the explicitly computed orbits after that. The attached patch does this: it moves the G-orbit code out of the methods for the appropriate simplicial complexes, replacing it with an explicit list of facets. It stores the G-orbit code as a stand-alone function, in case anyone wants to see how the facets were constructed in the first place.This also adds a minimal triangulation of the Klein bottle, and it uses proper reST formatting for references.
Component: algebraic topology
Keywords: sd40 simplicial
Author: John Palmieri
Reviewer: Travis Scrimshaw
Merged: sage-5.5.beta0
Issue created by migration from https://trac.sagemath.org/ticket/13244
The text was updated successfully, but these errors were encountered: