Update NTL to 6.0.0 #14876

vbraun · 2013-07-10T13:53:38Z

New upstream version.

Use git branch and tarball at:

http://boxen.math.washington.edu/home/jpflori/upstream/ntl-6.0.0.tar.bz2

Depends on #14333

CC: @nexttime @jpflori

Component: packages: standard

Author: Volker Braun, Jean-Pierre Flori

Branch: 8c9d711

Reviewer: Jean-Pierre Flori,François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/14876

The text was updated successfully, but these errors were encountered:

nexttime · 2013-07-10T14:30:21Z

comment:2

... and keep the $MAKE patches in mind (don't recall the ticket number right now), in case they're still necessary.

vbraun · 2013-07-10T14:48:51Z

comment:3

If you mean #14692: I won't included anything from that ticket as long as it is not finished.

nexttime · 2013-07-10T15:02:17Z

comment:4

Replying to @vbraun:

If you mean #14692: I won't included anything from that ticket as long as it is not finished.

Yes, that's what I meant.

It is finished, you just have to include the ($MAKE-related) patches.

I rebased Jean-Pierre's spkg at #2114 on mine, but then Jeroen felt he had to make trivial changes to that again, so that I would now again have to rebase mine on that of #2114, but that doesn't make sense if you're going to create a 6.0.0 anyway.

jpflori · 2013-07-10T15:29:35Z

comment:5

Yes please include #14692, there was just a trivial change to .hgignore to do and hg addremove but I completely forgot...

jpflori · 2013-07-10T15:31:43Z

comment:6

If Shoup has some interest on updating NTL again, we should definitely forward him our patches.

vbraun · 2013-07-10T15:36:42Z

Attachment: trac_14876_ntl_typedef.patch.gz

Initial patch

vbraun · 2013-07-10T15:40:11Z

comment:7

Please somebody go ahead and forward our patches...

jpflori · 2013-07-10T15:41:17Z

comment:8

Ok, I'll take care of forwarding the patches.

jpflori · 2013-07-10T15:53:17Z

comment:10

Groumpf, you just prevented me from posting that:

Please don't produce any spkg yet if not already done.
Before forwarding the patches I have to check they still apply onto 6.0.0, so I can draft an initial spkg on top of the one from #14692 and then you can fix whatever you want on top of it to ease the git transition and so on.

So I'll just check your spkg.

vbraun · 2013-07-10T16:48:07Z

comment:11

Singular doesn't build with NTL-6.0.0.

In the interest of getting this git-ready let's wait with the version bump.

vbraun · 2013-07-10T17:47:26Z

Work Issues: Singular

vbraun · 2013-07-10T19:00:22Z

comment:13

For the record, this is not fixed in Singular-3.1.6 (#14333), but is fixed in the upstream trunk https://groups.google.com/d/msg/libsingular-devel/aiMvEnN8qyg/cIFUsOXxK_MJ

jpflori · 2013-07-11T14:15:55Z

comment:14

Replying to @jpflori:

Ok, I'll take care of forwarding the patches.

Done and taken into account by Shoup.
It's on his todo list.
Great news.

jpflori · 2013-07-15T12:47:06Z

comment:15

Replying to @jpflori:

Replying to @jpflori:

Ok, I'll take care of forwarding the patches.

Done and taken into account by Shoup.
It's on his todo list.
Great news.

For future reference:
http://shoup.net/pipermail/ntl_shoup.net/2013-July/000041.html

Note that Victor's answer is not appearing there.

jpflori · 2013-12-31T13:26:54Z

Reviewer: Jean-Pierre Flori

jpflori · 2013-12-31T13:26:54Z

Dependencies: 14333

jpflori · 2013-12-31T13:26:54Z

Changed author from Volker Braun to Volker Braun, Jean-Pierre Flori

jpflori · 2013-12-31T13:26:54Z

Branch: u/jpflori/ticket/14876

jpflori · 2013-12-31T13:26:54Z

Changed work issues from Singular to segfaults

jpflori · 2013-12-31T13:26:54Z

Commit: 649e889

jpflori · 2013-12-31T13:26:54Z

comment:16

Singular update is positively reviewed.
I simply gitified everything and had to add a definition in the Singular patch for NTL 6.0.0 compat.
Let's get this in, I agree with Volker previous changes.
The only point left is quickly check that I did not screwed up the singular patch modif; and fix all the horrible segfaults.

New commits:

`649e889`	`Update NTL to 6.0.0.`
`eca3246`	`# Wed Jul 10 11:09:10 2013 -0400`

kiwifb · 2013-12-31T18:31:58Z

comment:23

Just to be clear. You git branch has both #14333 and this ticket. Which now that I wrote it, seem totally normal. With git, branch depending from another ticket will include change from the depending ticket.

jpflori · 2014-01-03T13:07:09Z

comment:24

I don't really know what should happen here.
For sure #14333 is a dependency.
But I forgot the # in the dependencies field so maybe that's what confused the git plugin.

kiwifb · 2014-01-04T01:07:31Z

comment:25

OK so I will try to do some testing of this. Apart from singular the following packages have a dependency to ntl:

flint
eclib
linbox
"sage-clib" and sage itself.

So my plan is to start from 6.1.beta2 add #14333, this ticket the flint upgrade and then rebuild the rest.

jpflori · 2014-02-17T15:50:04Z

comment:27

Replying to @kiwifb:

OK so I will try to do some testing of this. Apart from singular the following packages have a dependency to ntl:

flint

eclib

linbox

"sage-clib" and sage itself.

So my plan is to start from 6.1.beta2 add #14333, this ticket the flint upgrade and then rebuild the rest.

Any result on that? :)

kiwifb · 2014-02-17T18:23:43Z

comment:28

I dropped the ball because of other stuff. It will be easier to start from 6.2.beta2 since singular has been merged.

kiwifb · 2014-02-18T00:22:45Z

comment:29

Well so far it is extremely painful and not going very far. Switching branch with sage --dev checkout brought me in a state where I ended downloading older versions of sage's dependencies.
I have a thing about complaining about documentation, I'll certainly try to write some stuff down if I ever figure out things.

kiwifb · 2014-02-18T00:24:56Z

comment:30

Oh and the tarball cannot be found for good measure.

jpflori · 2014-02-18T07:54:12Z

comment:31

Typo indeed.

kiwifb · 2014-02-18T09:11:11Z

comment:33

Replying to @jpflori:

Typo indeed.

Can't believe I didn't notice that.

kiwifb · 2014-02-18T22:22:12Z

comment:34

Can you rebase the branch on 6.2.beta2? I have done:

./sage -dev checkout --ticket 14876
downloaded ntl-6.0.0.tar.bz2 to upstream
tried to rebuild flint...

cat build/pkgs/flint/package-version.txt 
2.3.p1

So that branch is still on the old versions of flint, singular and eclib. I need to be able to rebuild them to fully test the ticket.

sagetrac-git · 2014-02-18T22:24:07Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8c9d711`	`Merge remote-tracking branch 'trac/develop' into ticket/14876`

sagetrac-git · 2014-02-18T22:24:07Z

Changed commit from b6d64b4 to 8c9d711

kiwifb · 2014-02-18T22:26:16Z

comment:36

Do you know how I should checkout the changes? ./sage -dev checkout --ticket 14876 still leaves me with flint 2.3.p1.

jpflori · 2014-02-18T22:31:03Z

comment:37

I'd say

git fetch --all
git checkout -b test_ntl trac/u/jpflori/ticket/14876

Of course, you need to be tracking everything from the track git branch for that to work.
I don't remmeber the syntac, but something like

git fetch trac u/jpflori/ticket/14876
git checkout -b test_ntl trac/u/jpflori/ticket/14876

might do the trick if you don't.

I don't know how to do that with the dev scripts, sorry :(

kiwifb · 2014-02-19T01:02:20Z

comment:38

Forget about the dev scripts for now.

git fetch --all
git checkout u/jpflori/ticket/14876

worked. pity I didn't think of switching to a test branch earlier.
So far I did ./sage -f flint,eclib,singular,linbox and ./sage -b successfully.
Running ./sage -tp 12 --all --long now.

kiwifb · 2014-02-19T01:21:11Z

comment:39

----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 1234.6 seconds
    cpu time: 12669.7 seconds
    cumulative wall time: 13905.8 seconds

Yes!

kiwifb · 2014-02-19T01:21:11Z

Changed reviewer from Jean-Pierre Flori to Jean-Pierre Flori,François Bissey

kiwifb · 2014-02-19T20:40:14Z

comment:40

I just had a thought. Will the dependency of ntl need an artificial bump to be rebuilt or is the upgrade system able to cope with that?

vbraun · 2014-02-20T11:23:14Z

comment:41

Dependents of NTL will be rebuilt automatically.

I tried upgrading and it didn't produce a working Sage, but complete rebuild does. Possibly because wrong header files are used at one point, one of the limitations of our build system.

vbraun · 2014-02-20T23:17:08Z

Changed branch from u/jpflori/ticket/14876 to 8c9d711

jpflori · 2014-03-14T10:59:20Z

Changed commit from 8c9d711 to none

jpflori · 2014-03-14T10:59:20Z

comment:43

For those interested, 6.1 has been released: #15938 (nothing to see there yet).

vbraun added this to the sage-6.1 milestone Jul 10, 2013

vbraun added c: packages: standard labels Jul 10, 2013

vbraun assigned jdemeyer Jul 10, 2013

This comment has been minimized.

Sign in to view

vbraun changed the title ~~Update NTL to 6.0.0 and track all files~~ Update NTL to 6.0.0 Jul 10, 2013

This comment has been minimized.

Sign in to view

sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014

This comment has been minimized.

Sign in to view

kiwifb added s: positive review and removed s: needs review labels Feb 19, 2014

vbraun removed the s: positive review label Feb 20, 2014

vbraun closed this as completed in 28ce468 Feb 20, 2014

Update NTL to 6.0.0 #14876

Update NTL to 6.0.0 #14876

Comments

vbraun commented Jul 10, 2013

nexttime mannequin commented Jul 10, 2013

vbraun commented Jul 10, 2013

nexttime mannequin commented Jul 10, 2013

jpflori commented Jul 10, 2013

jpflori commented Jul 10, 2013

vbraun commented Jul 10, 2013

vbraun commented Jul 10, 2013

jpflori commented Jul 10, 2013

This comment has been minimized.

jpflori commented Jul 10, 2013

vbraun commented Jul 10, 2013

This comment has been minimized.

vbraun commented Jul 10, 2013

vbraun commented Jul 10, 2013

jpflori commented Jul 11, 2013

jpflori commented Jul 15, 2013

jpflori commented Dec 31, 2013

jpflori commented Dec 31, 2013

jpflori commented Dec 31, 2013

jpflori commented Dec 31, 2013

This comment has been minimized.

jpflori commented Dec 31, 2013

jpflori commented Dec 31, 2013

jpflori commented Dec 31, 2013

kiwifb commented Dec 31, 2013

jpflori commented Jan 3, 2014

kiwifb commented Jan 4, 2014

jpflori commented Feb 17, 2014

kiwifb commented Feb 17, 2014

kiwifb commented Feb 18, 2014

kiwifb commented Feb 18, 2014

jpflori commented Feb 18, 2014

This comment has been minimized.

This comment has been minimized.

kiwifb commented Feb 18, 2014

kiwifb commented Feb 18, 2014

sagetrac-git mannequin commented Feb 18, 2014

sagetrac-git mannequin commented Feb 18, 2014

kiwifb commented Feb 18, 2014

jpflori commented Feb 18, 2014

kiwifb commented Feb 19, 2014

kiwifb commented Feb 19, 2014

kiwifb commented Feb 19, 2014

kiwifb commented Feb 19, 2014

vbraun commented Feb 20, 2014

vbraun commented Feb 20, 2014

jpflori commented Mar 14, 2014

jpflori commented Mar 14, 2014