Do not import sagenb at startup

[fchapoton]

Component: misc

Keywords: startup

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/15335 @ da0d133

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15335

[fchapoton]

comment:1

Attachment: trac_15335.patch.gz

not ready, work in progress

[fchapoton]

Changed keywords from none to startup

[fchapoton]

comment:4

I suspect that the line

# For doctesting.
import sagenb

in sagenb/notebook/all.py could be the culprit. Could one juste remove this line ?

[jdemeyer]

Branch: u/jdemeyer/ticket/15335

[jdemeyer]

Commit: 4b2c470

[jdemeyer]

New commits:

4b2c470

Do not import sagenb at Sage startup

[jdemeyer]

Author: Jeroen Demeyer

[tscrim]

Changed branch from u/jdemeyer/ticket/15335 to u/tscrim/ticket/15335

[tscrim]

Changed commit from 4b2c470 to b28a85e

[tscrim]

comment:7

I get close to a 25% speedup in startup time. I've fixed the failing doctest from the patchbot in misc/dev_tools.py that I could reproduce, so if that also works for you Jeroen, then this is a positive review from me.

---

New commits:

b28a85e

Fixed doctest.

[tscrim]

Reviewer: Travis Scrimshaw

[fchapoton]

comment:8

When running sage -t -a, I got a failure (same as the bot) in src/sage/all.py

[jdemeyer]

comment:9

The problem is some of these doctests now depend on the --sagenb option given to the doctester.

[jdemeyer]

comment:10

This works:

./sage -t src/sage/all.py

This doesn't:

./sage -t --sagenb src/sage/all.py

[jdemeyer]

Changed branch from u/tscrim/ticket/15335 to u/jdemeyer/ticket/15335

[jdemeyer]

New commits:

214bf49	Only add sagenb globals if actually testing a sagenb file
da0d133	Merge branch 'u/tscrim/ticket/15335' of git://trac.sagemath.org/sage into ticket/15335

[jdemeyer]

Changed commit from b28a85e to da0d133

[jdemeyer]

comment:13

Travis: agreed with your change.

sagemath/sagetrac-mirror@214bf49 needs review to fix the --sagenb option issue.

[tscrim]

comment:14

LGTM^TM.

[jdemeyer]

comment:15

Never mind.

[ppurka]

comment:18

This has broken latex in the notebook. See sagemath/sagenb#195 for details.

[jdemeyer]

comment:19

Sorry guys :-(

[tscrim]

comment:20

Sorry!