Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoders and types for linear codes #20001

Closed
sagetrac-dlucas mannequin opened this issue Feb 2, 2016 · 16 comments
Closed

Decoders and types for linear codes #20001

sagetrac-dlucas mannequin opened this issue Feb 2, 2016 · 16 comments

Comments

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Feb 2, 2016

Decoders objects in coding theory are associated with a list of types, which are a list of keywords describing to the user the specificites of the underlying decoding algorithm.

For now, the types are not listed nor defined anywhere.

This ticket proposes to create a proper list of types and their definitions.

CC: @sagetrac-dlucas @ClementPernet @jlavauzelle @sagetrac-danielaugot

Component: coding theory

Keywords: rd3

Author: David Lucas, Johan Rosenkilde

Branch/Commit: 6e9c1dc

Reviewer: Johan Rosenkilde

Issue created by migration from https://trac.sagemath.org/ticket/20001

@sagetrac-dlucas sagetrac-dlucas mannequin added this to the sage-7.1 milestone Feb 2, 2016
@karandesai-96
Copy link
Mannequin

karandesai-96 mannequin commented Feb 3, 2016

comment:1

Could you please mention the files you intend to point out in the sage directory tree ?

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 3, 2016

comment:2

Hello,

I intend to create a list of types and their definitions in decoder.py (sage.coding.decoder), under the generic method decoder_type.

Actually, I originally did that in #19897, but after a discussion in #19623, we found that defining precisely types for decoders wasn't such an easy thing, hence this ticket.

David

@sagetrac-dlucas sagetrac-dlucas mannequin modified the milestones: sage-7.1, sage-7.2 Apr 13, 2016
@sagetrac-danielaugot
Copy link
Mannequin

sagetrac-danielaugot mannequin commented Aug 25, 2016

comment:4

Hi,

I do not clearly understand what is asked for.

Is a type something like "always_succes", "unique", "list" and so on ? I would then rather call that a property, since it is not a sage type.

Should that be done with a codes.decoders.decoder_types() call, which lists all decoder "types" , with an extremely clear docstring when querying with codes.decoders.decoder_types? ?

Daniel

@ralfarogit
Copy link
Mannequin

ralfarogit mannequin commented Aug 25, 2016

comment:5

I put my comments in the Issue #151 that Johan pointed out to me. It gives a suggestion on redefining the decoder types.

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

Branch: u/dlucas/decoder_types

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

comment:7

I pushed a table which contains a list of decoder types and their definitions.
Open for review.


New commits:

37e738fTable for decoder types

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

Commit: 37e738f

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

Changed keywords from none to rd3

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

Author: David Lucas

@johanrosenkilde
Copy link
Contributor

Changed branch from u/dlucas/decoder_types to u/jsrn/decoder_types

@johanrosenkilde
Copy link
Contributor

Changed commit from 37e738f to 6e9c1dc

@johanrosenkilde
Copy link
Contributor

comment:9

I made some improvements:

  • Some reformulations.
  • Used simpler table format for future modifications.
  • The doc was not present on Decoder instances (which is where most users will see them). I wrote introspection code which propagates the doc of decoder_type to _instance_decoder_type to fix this.

If you're OK, let's get this thing in the air!


New commits:

70e6052Reformulated some elements. Simpler table format
6e9c1dcDon't duplicate doc-string in decoder_type and _instance_decoder_type

@johanrosenkilde
Copy link
Contributor

Changed author from David Lucas to David Lucas, Johan Rosenkilde

@johanrosenkilde
Copy link
Contributor

Reviewer: Johan Rosenkilde

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 7, 2017

comment:11

I'm OK, setting to positive review.

David

@vbraun
Copy link
Member

vbraun commented Feb 8, 2017

Changed branch from u/jsrn/decoder_types to 6e9c1dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants