Remove PIP_INSTALL from sage-env

[embray]

#24014 deprecated the PIP_INSTALL environment variable in favor of the sdh_pip_install helper function. This ticket is to remove PIP_INSTALL entirely.

CC: @slel @tscrim @embray @jdemeyer

Component: build

Keywords: pip

Author: Frédéric Chapoton

Branch/Commit: ef11f05

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/24018

[jdemeyer]

comment:2

Related: some Python packages don't use pip at all:

gambit
numpy
pillow
scons
setuptools

For setuptools, this is obvious because it's a dependency of pip.

[slel]

Changed keywords from none to pip

[slel]

Changed dependencies from #24014 to #23983, #24014, #24092

[slel]

comment:3

In #24014, getting rid of the PIP_INSTALL environment variable was postponed for the sake of work in progress on brial and dot2tex.

Since #24092, brial no longer uses PIP_INSTALL.

Now that #23983 is closed, all that remains to do is to stop using PIP_INSTALL for dot2tex, allowing to remove PIP_INSTALL entirely.

[tscrim]

comment:4

Because I care about dot2tex.

[fchapoton]

New commits:

ef11f05

work on dot2tex spkg

[fchapoton]

Commit: ef11f05

[fchapoton]

Changed dependencies from #23983, #24014, #24092 to none

[fchapoton]

Branch: u/chapoton/24018

[fchapoton]

comment:9

Jeroen, would you have some time to look at this one ? This should be pretty clear, removal of the last instance of this variable. I have tested the package installation and it worked.

[embray]

comment:10

In retrospect there is one small possible use for a variable like this, in case users for some particular reason needed to override and/or extend the default flags passed to pip. I could sort of envision a reason for that in theory, though I don't know one explicitly.

In any case, the current implementation wouldn't work that way anyways, and something more like PIP_INSTALL_FLAGS would be better for that use case.

[embray]

Author: Frédéric Chapoton

[embray]

Reviewer: Erik Bray

[vbraun]

Changed branch from u/chapoton/24018 to ef11f05

[embray]

comment:12

This tickets were closed as fixed after the Sage 8.5 release.