Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegralLattice.all_overlattices #24859

Closed
simonbrandhorst opened this issue Feb 27, 2018 · 10 comments
Closed

IntegralLattice.all_overlattices #24859

simonbrandhorst opened this issue Feb 27, 2018 · 10 comments

Comments

@simonbrandhorst
Copy link

Enumerate all overlattices of a given lattice.

Depends on #24858

Component: linear algebra

Author: Simon Brandhorst

Branch/Commit: u/sbrandhorst/integrallattice_all_overlattices @ 43674b3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24859

@simonbrandhorst
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b4731dfMerge branch 'develop' into t/24859/integrallattice_all_overlattices

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2018

Commit: b4731df

@simonbrandhorst
Copy link
Author

comment:3

I think that after all this is not really useful. The reason being that the number
of overlattices is just too huge in any nontrivial example.

@simonbrandhorst simonbrandhorst removed this from the sage-8.2 milestone Oct 22, 2018
@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2018

comment:4

I don't think that is a reason to not include this. Two small things:

-- ``only_even`` -- bool (default: ``False``) return only the even overlattices.
+- ``only_even`` -- boolean (default: ``False``); return only the even overlattices

non - isotropic -> non-isotropic. Once changed, I am okay with setting this to a positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

43674b3small docfix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 21, 2018

Changed commit from b4731df to 43674b3

@simonbrandhorst
Copy link
Author

Reviewer: Travis Scrimshaw

@simonbrandhorst
Copy link
Author

comment:7

thank you.

@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:8

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants